Ensure we're checking the correct config data when using the clear of…#72
Open
Ensure we're checking the correct config data when using the clear of…#72
Conversation
…fline phase data function.
|
PASS [ 44.540s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency |
|
|
||
| fn set_chain_defaults(&mut self) { | ||
| async fn set_chain_defaults(&mut self, invalidate_chain_cache: bool) ->Result<()>{ | ||
|
|
There was a problem hiding this comment.
Empty line should be removed. The function body should start immediately after the opening brace.
| } | ||
|
|
||
| fn set_chain_defaults(&mut self) { | ||
| async fn set_chain_defaults(&mut self, invalidate_chain_cache: bool) ->Result<()>{ |
There was a problem hiding this comment.
Missing space before the opening brace in the Result type. Should be 'Result<()>' with proper spacing, or '-> Result<()>' with a space after the arrow.
Suggested change
| async fn set_chain_defaults(&mut self, invalidate_chain_cache: bool) ->Result<()>{ | |
| async fn set_chain_defaults(&mut self, invalidate_chain_cache: bool) -> Result<()> { |
DashKash54
reviewed
Jan 21, 2026
Contributor
DashKash54
left a comment
DashKash54
left a comment
There was a problem hiding this comment.
We're launching Naga keyset without presigs? So this won't be merged right now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fline phase data function.