Skip to content

Comments

[DONOTMERGE] FSM update to proper handle validators that aren't in union ( or have no realm assignment ) #104

Open
GTC6244 wants to merge 3 commits intomasterfrom
fix/handle_validator_not_in_union_in_FSM
Open

[DONOTMERGE] FSM update to proper handle validators that aren't in union ( or have no realm assignment ) #104
GTC6244 wants to merge 3 commits intomasterfrom
fix/handle_validator_not_in_union_in_FSM

Conversation

@GTC6244
Copy link
Contributor

@GTC6244 GTC6244 commented Feb 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 5, 2026 02:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorders conditional checks in the FSM (Finite State Machine) worker to handle validators that aren't in the union or have no realm assignment. The change moves the can_proceed check to execute after the validators union check, allowing the system to process validators union status even when the node lacks a realm assignment or when the network is paused.

Changes:

  • Moved the can_proceed check from before the validators union check to after it
  • This allows handle_not_part_of_validators_union to be called even when realm_id == 0 or the network is paused

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

PASS [ 44.480s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency
PASS [ 44.708s] (2/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_single_link
PASS [ 89.159s] (1/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_all_links

Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Garandor Garandor changed the title FSM update to proper handle validators that aren't in union ( or have no realm assignment ) [DONOTMERGE] FSM update to proper handle validators that aren't in union ( or have no realm assignment ) Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants