🦋 [Main] Naga Branch

[Ansonhkg]

WHAT

This is the main naga branch 🌶️

Getting started

// 1. install
pnpm install

// 2. build
pnpm build

// 3. test
NETWORK=naga-dev pnpm run test:e2e all

[Ansonhkg]

Packages published to prioritise usability of the naga-dev network:

🦋  success packages published successfully:
🦋  @lit-protocol/access-control-conditions@8.0.0-beta.2
🦋  @lit-protocol/access-control-conditions-schemas@8.0.0-beta.2
🦋  @lit-protocol/auth@8.0.0-beta.2
🦋  @lit-protocol/auth-helpers@8.0.0-beta.2
🦋  @lit-protocol/auth-services@2.0.0-beta.2
🦋  @lit-protocol/constants@8.0.0-beta.2
🦋  @lit-protocol/crypto@8.0.0-beta.2
🦋  @lit-protocol/lit-client@8.0.0-beta.2
🦋  @lit-protocol/logger@8.0.0-beta.2
🦋  @lit-protocol/networks@8.0.0-beta.2
🦋  @lit-protocol/schemas@8.0.0-beta.2
🦋  @lit-protocol/types@8.0.0-beta.2
🦋  @lit-protocol/wasm@8.0.0-beta.2

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ glitch003
✅ Ansonhkg
✅ Spacesai1or
✅ awisniew207
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Copilot]

Pull Request Overview

This is the main naga branch that introduces a comprehensive set of changes across the Lit Protocol JavaScript SDK, including the creation of a new Artillery testing package, significant refactoring of access control conditions with the introduction of new schema-based validation, and removal of wrapped-keys testing files. The PR represents a major restructuring with the addition of comprehensive load testing capabilities and modernized access control condition handling.

Key changes:

• Added a new Artillery package for load testing with various test configurations
• Introduced access-control-conditions-schemas package with Zod-based validation
• Completely refactored access-control-conditions package with new validator, builder pattern, and improved type safety
• Removed all wrapped-keys related test files from local-tests

Reviewed Changes

Copilot reviewed 223 out of 1442 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/artillery/*	New Artillery load testing package with configurations and metadata
packages/access-control-conditions-schemas/*	New schema validation package using Zod for access control conditions
packages/access-control-conditions/src/lib/*	Complete refactor with new validation, builder pattern, and modernized utilities
local-tests/tests/wrapped-keys/*	Removal of all wrapped-keys test files
nx.json, package.json	Updated project configuration and dependencies

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The inline comment raises a valid concern about error handling safety. Consider documenting the expected behavior when decimal retrieval fails or implementing proper error handling rather than just logging and continuing.

Suggested change

	logger.info(`Failed to get decimals for ${acc.contractAddress}`); // is this safe to fail and continue?
	logger.warn(`Failed to get decimals for ${acc.contractAddress}, using default of 18. Error: ${e}`);
	decimals = 18; // Default to 18 decimals if retrieval fails

[Copilot]

The conversion from ArrayBuffer to Uint8Array to Buffer to hex string could be simplified to Buffer.from(hashed).toString('hex') since Buffer.from() can directly accept ArrayBuffer.

Suggested change

	return Buffer.from(new Uint8Array(hashed)).toString('hex');
	return Buffer.from(hashed).toString('hex');

[Copilot]

Using as any to bypass type checking should be avoided. Instead, define the proper type or use a type assertion that's more specific to the expected type.

Suggested change

	comparator: comparator || ('=' as any),
	comparator: comparator || '=',

[Copilot]

Another instance of using as any to bypass type checking. This pattern appears multiple times and should be replaced with proper typing.

Suggested change

	comparator: comparator || ('=' as any),
	comparator: comparator || '=',