Skip to content

Fix base64url character replacement #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsamtrum wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −2
Open

Fix base64url character replacement #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/uint8arrays/src/lib/uint8arrays.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,12 @@ describe('turn to base64urlpad', () => {

expect(base64).toBe('SGVsbG8sIFdvcmxkIQ');
});

it('should replace every base64url character when encoding and decoding', () => {
const bytes = new Uint8Array([251, 239, 255, 251, 239, 255]);
const encoded = uint8arrayToString(bytes, 'base64urlpad');

expect(encoded).toBe('--__--__');
expect(uint8arrayFromString(encoded, 'base64urlpad')).toEqual(bytes);
});
});
4 changes: 2 additions & 2 deletions packages/uint8arrays/src/lib/uint8arrays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ export function uint8ArrayToBase64(uint8Array: Uint8Array): string {

function base64UrlPadToBase64(base64UrlPadStr: string): string {
return (
base64UrlPadStr.replace('-', '+').replace('_', '/') +
base64UrlPadStr.replace(/-/g, '+').replace(/_/g, '/') +
'='.repeat((4 - (base64UrlPadStr.length % 4)) % 4)
);
}

function base64ToBase64UrlPad(base64Str: string): string {
return base64Str.replace('+', '-').replace('/', '_').replace(/=+$/, '');
return base64Str.replace(/\+/g, '-').replace(/\//g, '_').replace(/=+$/, '');
}

export function uint8arrayFromString(
Expand Down