Open
Conversation
SHAO-Jiaqi757
requested review from
RuishanFang and
SHAO-Jiaqi757
and removed request for
SHAO-Jiaqi757
RuishanFang
reviewed
Jul 23, 2025
mas_arena/agents/chateval.py
Outdated
| # Handle case where response_content might be a list or other type | ||
| content = response_content if isinstance(response_content, str) else str(response_content) | ||
| if self.chat_history is None: | ||
| self.chat_history = [] |
Collaborator
There was a problem hiding this comment.
This check is unnecessary since chat_history is already initialized in the post_init method.
mas_arena/agents/chateval.py
Outdated
| "solution": response.content | ||
| } | ||
|
|
||
| async def generate_response(self, context: str) -> Any: |
Collaborator
There was a problem hiding this comment.
Add specific type annotations to improve code clarity
Replace generic Any return type with more specific type annotations like
Dict[str, Union[Any, str]]
mas_arena/agents/chateval.py
Outdated
| self.chat_history.append({"role": "human", "human": context}) | ||
| self.chat_history.append({"role": "ai", "ai": content}) | ||
|
|
||
| def _build_messages(self, context: str) -> List: |
Collaborator
There was a problem hiding this comment.
Add specific type annotations to improve code clarity
Replace the generic List return type with the more specific
List[Union[SystemMessage, HumanMessage, AIMessage]] to clearly indicate
the expected message types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chateval.pyto enhance the performance.extending.mdcorrespondingly.#44