[Refactor] #100 - Refactoring snake_case to camelCase#101
Open
shimseohyun wants to merge 3 commits into
Open
Conversation
sayyyho
approved these changes
Feb 1, 2025
Contributor
sayyyho
left a comment
sayyyho
left a comment
There was a problem hiding this comment.
snake 케이스 camel 케이스로 변경하시느라 고생하셨어요!! 웹을 잠깐 쉬다가 보니까 낯설었지만, 공부하면서 잘 봤습니다ㅎㅎ 다시 리팩 레츠고 하시져!~!
Comment on lines
+37
to
+51
| extends Array<{ | ||
| id: number; | ||
| name: string; | ||
| description: string; | ||
| location: string; | ||
|
|
||
| is_operated: BoothStatus; | ||
| thumbnail: string; | ||
|
|
||
| waiting_count: number; | ||
| total_waiting_teams: number; | ||
|
|
||
| is_waiting: boolean; | ||
| waiting_status: WaitingStatus | null; | ||
| }> {} |
Comment on lines
+68
to
+76
| openTime: response.open_time, | ||
| closeTime: response.close_time, | ||
| waitingCount: response.waiting_count, | ||
| isWaiting: response.is_waiting, | ||
| waitingStatus: response.waiting_status, | ||
| isOperated: response.is_operated, | ||
| waitingID: response.waiting_id, | ||
| totalWaitingTeams: response.total_waiting_teams, | ||
| waitingTeamsAhead: response.waiting_teams_ahead, |
Comment on lines
81
to
+89
| export const postWaitingRegister = async ({ | ||
| boothId, | ||
| party_size, | ||
| }: RegisterWaitingRequest): Promise<PostWaitingRegisterProps | null> => { | ||
| const response = await postResponse<PostWaitingRegisterProps>( | ||
| `api/v1/waitings/${boothId}/register`, | ||
| { party_size } | ||
| ); | ||
| ...props | ||
| }: RegisterWaitingRequest): Promise<PostWaitingRegisterResponse | null> => { | ||
| const response = await postResponseNew< | ||
| PostWaitingRegisterBody, | ||
| PostWaitingRegisterResponse | ||
| >(`api/v1/waitings/${props.boothID}/register`, { | ||
| party_size: props.partySize, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
👷 작업한 내용
🚨 참고 사항
현재 run build로 에러 안 나는 것만 확인했어요.
서버 돌리면 어떤 일이 일어날지 모름...
🖥️ 주요 코드 설명
booth, waiting interface 생성
자주 사용하는 데이터 구조인
booth와waiting의 interface를 생성했습니다.해당 데이터를 사용하는 경우 props로 받아서 사용해주시면 돼요.
✅ Check List
📟 관련 이슈