Skip to content

Issue #948: Surface spam-folder hint on Login page, drop email-body redundancy #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjagg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue #948: Surface spam-folder hint on Login page, drop email-body redundancy #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cloudformation/cognito-selfserve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ Resources:
Enter this code on the registration page to complete sign-up. If
you didn't request this account, no action is needed and the
account will not be created.

(If you don't see this in your inbox, please check Spam / Junk.)
Schema:
- Name: email
AttributeDataType: String
Expand Down
31 changes: 23 additions & 8 deletions frontends/mdr-frontend/src/pages/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,29 @@ const Login: React.FC = () => {
)}

{isCognitoEnabled ? (
<Button
size="3"
className="w-full"
disabled={isLoading}
onClick={handleCognitoLogin}
>
{isLoading ? "Redirecting..." : "Sign In / Register"}
</Button>
<>
<Button
size="3"
className="w-full"
disabled={isLoading}
onClick={handleCognitoLogin}
>
{isLoading ? "Redirecting..." : "Sign In / Register"}
</Button>
{/* The Cognito hosted UI sign-up flow emails a 6-digit code,
and Cognito's default sender domain
(no-reply@verificationemail.com) often hits Gmail / Outlook
spam filters. Surface the spam-folder reminder *here* — at
the moment the user is about to bounce to Cognito to sign
up and is about to be waiting for that code — rather than
inside the email body itself, where it's redundant if they
see the mail and useless if they don't. Issue #948 (@cbeach47
review of #946). */}
<Text size="1" color="gray" align="center" mt="1">
If you're registering, you'll receive a 6-digit code by email.
Check your Spam folder if it doesn't arrive within a minute.
</Text>
</>
) : (
<form onSubmit={handleLegacySubmit}>
<Flex direction="column" gap="3">
Expand Down