fix: correct domain name after change

[bjagg]

Checklist

• commit message follows commit guidelines (see commitlint.config.mjs)
• tests are included (unit and/or integration tests)
• all tests are successful
• documentation is changed or added (in /docs directory)
• code passes linting checks (uv run ruff check)
• code passes formatting checks (uv run ruff format)
• code passes type checking (uv run ty check)
• pre-commit hooks have been run successfully
• database schema changes: migration files created and CHANGELOG.md updated
• API changes: base (Python code) documentation in docs/
  and project README updated
• configuration changes: relevant folder README updated
• breaking changes: added to MIGRATION.md with upgrade instructions
  and CHANGELOG.md entry

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality
  to not work as expected)
• Documentation update
• Infrastructure/deployment change
• Performance improvement
• Code refactoring

Description of Change

The domain names for dev services were changed to add ".dev" in to make clear the services are part of dev rather than demo environment. Some URLs were not updated. This PR resolves those.

Related Issues

Closes # [[add Github issue number]]
Resolves #802

Testing

• Manual testing performed
• Automated tests added/updated
• Integration testing completed

Project Area(s) Affected

• bases/
• components/
• orchestrators/
• frontends/
• deployments/
• CloudFormation/SAM templates
• Database schema
• API endpoints
• Documentation
• Testing

Additional Notes

These changes only affect deployment to AWS, so testing is limited before merging.

[Copilot]

Pull request overview

This pull request corrects domain name references in development environment configurations after the dev services domain was changed from *.lif.unicon.net to *.dev.lif.unicon.net. This change addresses CORS issues that were preventing dev MDR login (issue #802).

Changes:

• Updated CloudFormation README documentation to show correct domain name examples for dev and demo environments
• Fixed dev MDR frontend workflow to construct API URLs with the .dev. subdomain
• Fixed dev advisor app workflow URLs to include the .dev. subdomain

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
cloudformation/README.md	Updated domain name examples in documentation to reflect .dev. and .demo. patterns
.github/workflows/lif_mdr_frontend.yml	Modified VITE_API_URL construction to include ENV_NAME for proper dev domain
.github/workflows/lif_advisor_app.yml	Updated hardcoded advisor API URLs to include .dev. subdomain

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The URL construction pattern here differs from the demo workflow (demo_lif_mdr_frontend.yml). In the demo workflow, DOMAIN is set to 'demo.lif.unicon.net' and URLs are constructed as 'mdr-api.$DOMAIN', while here you're using 'mdr-api.$ENV_NAME.$DOMAIN' with DOMAIN='lif.unicon.net'. Both approaches work, but consider standardizing the pattern across environments by updating the DOMAIN variable to 'dev.lif.unicon.net' and using the simpler 'mdr-api.$DOMAIN' construction like the demo workflow. This would improve maintainability and consistency.