Skip to content

Add HPGe processing capability to activation_foils workflow#90

Merged
RemDelaporteMathurin merged 50 commits intoLIBRA-project:mainfrom
cdunn314:hpge
Jan 14, 2026
Merged

Add HPGe processing capability to activation_foils workflow#90
RemDelaporteMathurin merged 50 commits intoLIBRA-project:mainfrom
cdunn314:hpge

Conversation

@cdunn314
Copy link
Contributor

@cdunn314 cdunn314 commented Jan 8, 2026

Users existing functions and workflow for NaI activation foil analysis, but adds HPGe processing capability.

This mostly just adds a detector_type attribute to the Measurement class, adds peak search parameters for common check sources in the get_peak() function and allows for peak search parameter kwargs in the get_calibration_data() function.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 88.09524% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.25%. Comparing base (2569f9b) to head (645eb79).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...lbox/neutron_detection/activation_foils/compass.py 87.17% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   87.11%   87.25%   +0.14%     
==========================================
  Files          19       19              
  Lines        1506     1562      +56     
==========================================
+ Hits         1312     1363      +51     
- Misses        194      199       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cdunn314 and others added 12 commits January 13, 2026 18:33
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@cdunn314
Copy link
Contributor Author

The CI is failing now due to not being able to find the PRT .h5 file... I tried rerunning the tests, but still came back with the same error.

@RemDelaporteMathurin
Copy link
Member

The CI is failing now due to not being able to find the PRT .h5 file... I tried rerunning the tests, but still came back with the same error.

so this happens when the CI runner fails to download the .h5 file from Zenodo.. as long as the tests are not failing we're good to go

Copy link
Member

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this whenever you're ready! Good job @cdunn314

@cdunn314
Copy link
Contributor Author

Happy to merge this whenever you're ready! Good job @cdunn314

Thanks! Ready to merge

@RemDelaporteMathurin RemDelaporteMathurin merged commit e3f81c4 into LIBRA-project:main Jan 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants