Add function to build BABY-1L geometry and corresponding test#89
Open
davidepettinari wants to merge 5 commits intoLIBRA-project:mainfrom
Open
Add function to build BABY-1L geometry and corresponding test#89davidepettinari wants to merge 5 commits intoLIBRA-project:mainfrom
davidepettinari wants to merge 5 commits intoLIBRA-project:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 87.11% 88.22% +1.10%
==========================================
Files 19 20 +1
Lines 1506 1647 +141
==========================================
+ Hits 1312 1453 +141
Misses 194 194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new function,
baby_geometry, to the toolbox for building the BABY-1L geometry.Previously, the geometry definition was duplicated across individual simulation scripts, for example in BABY-1L-run-1.
By centralizing it in a single function, the codebase becomes simpler, cleaner, and more readable.
A dedicated test file,
test_baby.py, has been added in thetest/directory to ensure that the BABY-1L geometry is correctly generated and behaves as expected.