-
Notifications
You must be signed in to change notification settings - Fork 1
π Fix assert_exit_code, improve exit code handling for all #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a8d578
π Fix assert_exit_code, improve exit code handling for all
1c2c46e
π¨ Remove trailing whitespace
707f00c
π¨ Remove trailing whitespace
92a4766
π¨ Remove trailing whitespace
3442ab9
β»οΈ Refactor, improve, and centralize exit code handling
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # shellcheck shell=bash | ||
| # | ||
| # Copyright 2025 The Linux Foundation | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| # core::test::run_without_exit_on_error | ||
| # Executes a command with 'set -e' and 'set -u' temporarily disabled, then restores the original state. | ||
| # | ||
| # Description: | ||
| # This helper function temporarily disables the 'set -e' (errexit) and 'set -u' (nounset) | ||
| # shell options before executing a command, allowing the command to return any exit code | ||
| # and reference undefined variables without causing the shell to exit. After execution, | ||
| # it restores the original shell option states and outputs the exit code to stdout. | ||
| # The function itself always returns 0 to prevent triggering 'set -e'. | ||
| # This is particularly useful in test assertions that need to capture and validate | ||
| # specific exit codes. | ||
| # | ||
| # Usage: | ||
| # exitCode=$(core::test::run_without_exit_on_error <command> [args...]) | ||
| # | ||
| # Parameters: | ||
| # command - The command or function to execute. | ||
| # args... - Optional arguments to pass to the command. | ||
| # | ||
| # Outputs: | ||
| # The exit code of the executed command (to stdout). | ||
| # | ||
| # Example: | ||
| # exitCode=$(core::test::run_without_exit_on_error some_command arg1 arg2) | ||
| function core::test::run_without_exit_on_error() { | ||
| local restoreExitOnError=false | ||
| local restoreUnsetVarError=false | ||
|
|
||
| if [[ $- =~ e ]]; then | ||
| restoreExitOnError=true | ||
| fi | ||
|
|
||
| if [[ $- =~ u ]]; then | ||
| restoreUnsetVarError=true | ||
| fi | ||
|
|
||
| set +e | ||
| set +u | ||
| "$@" &>/dev/null | ||
| local exitCode=$? | ||
|
|
||
| if [[ $restoreExitOnError == true ]]; then | ||
| set -e | ||
| fi | ||
|
|
||
| if [[ $restoreUnsetVarError == true ]]; then | ||
| set -u | ||
| fi | ||
|
|
||
| echo "$exitCode" | ||
| return 0 | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.