fix: empty channels should be allowed #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you DomKal11 for your first pull request to AsyncAPI.NET repository. Please check out our contributors guide.
UlrikSandberg
approved these changes
Sep 5, 2025
DomKal11
changed the title
DomKal11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This change updates the AsyncAPI document validation logic to allow an empty
channelsobject (channels: {}) as valid. According to the AsyncAPI, thechannelsfield is required in every document, but it may be empty. The validation now only checks for the presence of thechannelsfield, not its contents.AsyncAPI Spec Reference:
The AsyncAPI standard requires the presence of the
channelsobject, but does not require it to contain any channels (this is not specifically described). An empty object should be valid.https://v2.asyncapi.com/docs/reference/specification/v2.6.0#channelsObject
More information to be found also here: https://github.com/LEGO/api-management-management-api/issues/3012
Changelog
Related Issues