fix: null representation for AvroField 'default' property #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisualBean
force-pushed
the
alex/avroschema_defaultnull
branch
from
225d537 to
71dea01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
SerializeV2method inAvroField.csand adds a new test case inAvroSchema_Should.csto handle serialization of default null values correctly.Handling default null values in serialization:
src/LEGO.AsyncAPI/Models/Avro/AvroField.cs: Modified theSerializeV2method to check if the default value is "null" and write a JSON null value accordingly.Adding a test case for serialization:
test/LEGO.AsyncAPI.Tests/Models/AvroSchema_Should.cs: Added a new test caseSerialize_WithDefaultNull_SetJsonNullto verify that the default null value is correctly serialized as JSON null.