Wireup Department History Timeline API by sehansi-9 · Pull Request #147 · LDFLK/openginxplore

sehansi-9 · 2026-03-17T09:04:32Z

Wireup the new api, introduce useDepartmentHistory hook and remove history enriching logic from DepartmentHistoryTimeline component

closes #66

…tmentHistoryTimeline component

gemini-code-assist · 2026-03-17T09:04:47Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the architecture for displaying department history by centralizing data fetching and processing. It introduces a dedicated API endpoint and a custom React hook, useDepartmentHistory, to handle the retrieval and initial structuring of historical department data. This change streamlines the DepartmentHistoryTimeline component, making it leaner, more focused on presentation, and easier to maintain by offloading data management responsibilities to the new hook.

Highlights

New API Endpoint: Introduced a new API endpoint /department-history/{departmentId} to fetch historical data for departments.
New React Hook: Created a useDepartmentHistory React Query hook to abstract and manage the fetching of department history data.
Component Refactoring: Refactored the DepartmentHistoryTimeline component to consume data from the new useDepartmentHistory hook, removing complex data fetching and enrichment logic directly from the component.

Changelog

src/hooks/useDepartmentHistory.js
- Created a new React Query hook useDepartmentHistory to fetch department history data.
- Configured the hook with queryKey, queryFn, enabled status, staleTime, and gcTime for efficient data management.
src/pages/DepartmentPage/components/DepartmentHistoryTimeline.jsx
- Removed extensive useEffect logic responsible for fetching and enriching department history data.
- Replaced manual data fetching and state management with the useDepartmentHistory hook.
- Simplified the rendering logic to directly consume data from the new hook.
- Removed imports related to redux, utils, and api that are no longer needed for data enrichment.
src/services/services.jsx
- Added a new asynchronous function getDepartmentHistory to make API calls to the /department-history/{departmentId} endpoint.

Activity

The pull request was created by sehansi-9.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request is a great improvement, refactoring the DepartmentHistoryTimeline component to use a new useDepartmentHistory hook and a dedicated API endpoint. This change significantly simplifies the frontend by moving complex data processing to the backend. My feedback focuses on making the timeline component more robust by ensuring data is always sorted correctly and by using more stable keys for list rendering.

gemini-code-assist · 2026-03-17T09:05:48Z

+            {departmentHistory.map((entry, idx) => {
+              return (
+                <VerticalTimelineElement
+                  key={idx}


Using the array index as a key is not recommended, as it can lead to incorrect behavior and performance issues when the list is sorted or items are added/removed. It's best to use a unique and stable identifier from the data. Since a simple unique ID doesn't seem to be available on the entry object, you can create a composite key from its properties.

Suggested change

key={idx}

key={`${entry.ministry_name}-${entry.period}`}

yasandu0505 · 2026-03-19T06:30:59Z

-  }, [selectedDepartment]);
+  const {
+    data: departmentHistory,
+    isLoading,


catch the error state as well in case the request breaks we need it to fallback

Suggested change

isLoading,

isLoading,

error

yasandu0505 · 2026-03-19T06:34:12Z

        <div className="flex justify-center items-center h-20">
-          <ClipLoader color={colors.textPrimary} loading={loading} size={25} />
+          <ClipLoader color={colors.textPrimary} loading={isLoading} size={25} />
+        </div>


Add a fallback component here in case the api throws an error.

Suggested change

</div>

</div>

) : error ? (

<p className="text-primary mt-5">Error loading department history.</p>

this is just an idea for you to look at, implement a fallback ui for the DepartmentHistoryTimeline.

ChanukaUOJ

Initial Comments!

ChanukaUOJ · 2026-03-20T05:05:08Z

Make sure all the unused functions are removed from this file

will be addressed here #114

ChanukaUOJ · 2026-03-20T05:18:08Z

+            <h2 className="text-md font-semibold text-gray-900 dark:text-white mb-2">
+              Department History Not Available
+            </h2>


No need this one

ChanukaUOJ

LGTM!

feat: implement useDepartmentHistory hook and integrate it into Depar…

bab570a

…tmentHistoryTimeline component

gemini-code-assist bot reviewed Mar 17, 2026

View reviewed changes

sehansi-9 requested a review from ChanukaUOJ March 17, 2026 10:35

yasandu0505 reviewed Mar 19, 2026

View reviewed changes

fix: handle error state in DepartmentHistoryTimeline component

55b67cd

ChanukaUOJ reviewed Mar 20, 2026

View reviewed changes

fix: simplify error message in DepartmentHistoryTimeline component

614d50d

ChanukaUOJ approved these changes Mar 20, 2026

View reviewed changes

ChanukaUOJ merged commit 1e232db into LDFLK:main Mar 20, 2026
1 check passed

-        </div>
+        </div>
+    ) : error ? (
+        <p className="text-primary mt-5">Error loading department history.</p>

Conversation

sehansi-9 commented Mar 17, 2026

Uh oh!

gemini-code-assist bot commented Mar 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChanukaUOJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChanukaUOJ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants