[RTI][TOOL] Enable multiple emails and contact nos for receivers by ChanukaUOJ · Pull Request #152 · LDFLK/RTI-Tracker

ChanukaUOJ · 2026-05-21T09:33:19Z

No description provided.

…eiver

gemini-code-assist

Code Review

This pull request transitions the receiver contact information from single string fields to JSONB arrays for both emails and contact numbers. This change involves updates to the SQL schema, seed data, Pydantic models, and the service layer. Review feedback highlights that the removal of UNIQUE constraints on these fields makes existing error handling logic in the service layer unreachable and renders the conflict-related unit tests ineffective. Additionally, it is recommended to use generic SQLAlchemy JSON types instead of dialect-specific JSONB to maintain database flexibility and to ensure contact numbers are stored without hyphens per project standards.

ChanukaUOJ · 2026-05-25T02:34:59Z

/gemini review

gemini-code-assist

Code Review

This pull request migrates the receiver contact information from single string fields to JSONB lists for both emails and contact numbers across the backend and frontend. Key changes include database schema updates, Pydantic model adjustments, and the introduction of a TagInput component in the frontend for managing multiple entries. Feedback focuses on maintaining data consistency by removing hyphens from stored phone numbers, restoring regex validation for contact lists using Annotated, cleaning up unreachable error handling in the service layer, and improving type safety by avoiding 'as any' in the frontend validation logic.

zaeema-n · 2026-05-27T05:17:06Z

    position_id: UUID = Field(foreign_key="positions.id", description="ID of the position")
    institution_id: UUID = Field(foreign_key="institutions.id", description="ID of the institution")
-    email: Optional[str] = Field(None, unique=True, description="Email of the receiver")
+    emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of email of the receiver")


Suggested change

emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of email of the receiver")

emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of emails of the receiver")

zaeema-n · 2026-05-27T05:17:17Z

+    emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of email of the receiver")
    address: Optional[str] = Field(None, description="Address of the receiver")
-    contact_no: Optional[str] = Field(None, unique=True, description="Contact number of the receiver")
+    contact_nos: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of contact number of the receiver")


Suggested change

contact_nos: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of contact number of the receiver")

contact_nos: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of contact numbers of the receiver")

zaeema-n · 2026-05-27T05:29:09Z

-((SELECT id FROM positions WHERE name = 'Department Head' LIMIT 1), (SELECT id FROM institutions WHERE name = 'Public Service Commission' LIMIT 1), 'head.psc@gov.lk', 'Gampaha', NULL);
+INSERT INTO receivers (position_id, institution_id, emails, address, contact_nos) VALUES 
+((SELECT id FROM positions WHERE name = 'Information Officer' LIMIT 1), (SELECT id FROM institutions WHERE name = 'Ministry of Health' LIMIT 1), '["io.health@gov.lk"]', NULL, '["0112444555"]'),
+((SELECT id FROM positions WHERE name = 'Designated Officer' LIMIT 1), (SELECT id FROM institutions WHERE name = 'Department of Education' LIMIT 1), '["do.edu@gov.lk"]', NULL, '[]'),


Can we not keep empty values for contact nos or emails as NULL? Does it have to be an empty list?

zaeema-n · 2026-05-27T05:31:50Z

    position_id: Optional[UUID] = Field(None, alias="positionId", description="ID of the position")
    institution_id: Optional[UUID] = Field(None, alias="institutionId", description="ID of the institution")
-    email: Optional[EmailStr] = Field(None, description="Email of the receiver")
+    emails: Optional[List[EmailStr]] = Field(None, description="List of receiver Emails")


Suggested change

emails: Optional[List[EmailStr]] = Field(None, description="List of receiver Emails")

emails: Optional[List[EmailStr]] = Field(None, description="List of receiver emails")

zaeema-n · 2026-05-29T03:12:52Z

This file is called receiver.py but the file in response_models is receivers.py

zaeema-n · 2026-05-29T03:15:05Z

-    email: Optional[str] = Field(
-        None, description="Email of the receiver"
+    emails: Optional[List[str]] = Field(
+        None, description="Email list of the receiver"


Suggested change

None, description="Email list of the receiver"

None, description="List of receiver emails"

zaeema-n · 2026-05-29T03:15:22Z

-        serialization_alias="contactNo",
-        description="Contact number of the receiver"
+        serialization_alias="contactNos",
+        description="Contact number list of the receiver"


Suggested change

description="Contact number list of the receiver"

description="List of receiver contact numbers"

zaeema-n · 2026-05-29T03:15:56Z

    position_id: UUID = Field(..., alias="positionId", description="ID of the position")
    institution_id: UUID = Field(..., alias="institutionId", description="ID of the institution")
-    email: Optional[EmailStr] = Field(None, description="Email of the receiver")
+    emails: Optional[List[EmailStr]] = Field(None, description="List of receiver Emails")


Suggested change

emails: Optional[List[EmailStr]] = Field(None, description="List of receiver Emails")

emails: Optional[List[EmailStr]] = Field(None, description="List of receiver emails")

zaeema-n · 2026-05-29T03:16:15Z

    position: PositionShortResponse = Field(..., description="Position object of the receiver")
    institution: InstitutionShortResponse = Field(..., description="Institution object of the receiver")
-    email: Optional[str] = Field(None, description="Email of the receiver")
+    emails: Optional[List[str]] = Field(None, description="Email list of the receiver")


Suggested change

emails: Optional[List[str]] = Field(None, description="Email list of the receiver")

emails: Optional[List[str]] = Field(None, description="List of receiver emails")

zaeema-n · 2026-05-29T03:16:30Z

+    emails: Optional[List[str]] = Field(None, description="Email list of the receiver")
    address: Optional[str] = Field(None, description="Address of the receiver")
-    contact_no: Optional[str] = Field(None, serialization_alias="contactNo", description="Contact number of the receiver")
+    contact_nos: Optional[List[str]] = Field(None, serialization_alias="contactNos", description="Contact number list of the receiver")


Suggested change

contact_nos: Optional[List[str]] = Field(None, serialization_alias="contactNos", description="Contact number list of the receiver")

contact_nos: Optional[List[str]] = Field(None, serialization_alias="contactNos", description="List of receiver contact numbers")

[BACKEND] enable multiple emails and contacts storing feature for rec…

c1f0d99

…eiver

gemini-code-assist Bot reviewed May 21, 2026

View reviewed changes

bot comments resolved

5e1e4f5

ChanukaUOJ requested a review from zaeema-n May 21, 2026 10:10

multiple emails and numbers showing in the frontend

ef9af4a

gemini-code-assist Bot reviewed May 25, 2026

View reviewed changes

bot comment resolved

9e9e60e

ChanukaUOJ linked an issue May 27, 2026 that may be closed by this pull request

[RTI][TOOL] Enable multiple emails and contact nos for receivers #150

Open

zaeema-n reviewed May 27, 2026

View reviewed changes

zaeema-n reviewed May 29, 2026

View reviewed changes

	emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of email of the receiver")
	emails: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of emails of the receiver")

	contact_nos: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of contact number of the receiver")
	contact_nos: Optional[List[str]] = Field(default_factory=list, sa_column=Column(JSON), description="List of contact numbers of the receiver")

	emails: Optional[List[EmailStr]] = Field(None, description="List of receiver Emails")
	emails: Optional[List[EmailStr]] = Field(None, description="List of receiver emails")

	None, description="Email list of the receiver"
	None, description="List of receiver emails"

	description="Contact number list of the receiver"
	description="List of receiver contact numbers"

	emails: Optional[List[str]] = Field(None, description="Email list of the receiver")
	emails: Optional[List[str]] = Field(None, description="List of receiver emails")

Conversation

ChanukaUOJ commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChanukaUOJ commented May 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChanukaUOJ commented May 21, 2026 •

edited

Loading