Fix department name in department history response#107
Fix department name in department history response#107lahiruudayakumara wants to merge 2 commits into
Conversation
Add department_name to the department history timeline response and keep renamed departments separate during timeline collapsing. Update the API contract and service tests for the response change, and adjust async error-path tests to avoid unawaited coroutine warnings while running the suite. Fixes LDFLK#106
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds department_name to the organization API contract and updates the department_history_timeline service to include department names and source IDs in the response. The logic for collapsing timeline entries was updated to account for these new fields, and several tests were adjusted to verify the changes. Review feedback suggests completing the API examples in the contract and using pre-formatted period strings in the service implementation to ensure consistency and simplify consumer usage.
|
hi @lahiruudayakumara |
Keep internal gap records structurally consistent by setting minister_name for placeholder entries and clarify why the timeline uses raw timestamps until the final response formatting step. Validated with the full test suite. Refs LDFLK#106
lahiruudayakumara
left a comment
lahiruudayakumara
left a comment
There was a problem hiding this comment.
fix: add minister_name field to gap timeline entries for consistent response structure
Refs #106
3 participants
Summary
department_nameto the department history timeline responseFixes #106