Open
Conversation
0ff1fc9 to
51a6fe0
Compare
aac53e8 to
acaf457
Compare
51a6fe0 to
8a3c7da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is one of two related PRs which have been split for easier reviews. In this PR, we first add the stacking core and data model. The next PR (441) will integrate these into the pipeline.
StackFrameDB model and helper functions to keep track of frames during smartstack observationsrun_pipeline_stages: add return value with the reduced image filepathOverall, these changes are intended to get smartstacking ready with everything except the stacking algorithm itself.
One particular change I want to flag is that stage_utils.py,
run_pipeline_stagesused to have no return value, but now returns the images that were just processed, in order to easily pass the filepath to the stack db and worker. I don't think this causes problems in any existing calling code, but since it modifies a core banzai function I want to be sure.