Skip to content

Update JWT core package so the latest Token Factory supporting Cognito token gets used for Google groups auth.#210

Merged
Duslerke merged 1 commit intodevelopmentfrom
bump-jwt-for-cognito-token-support
Feb 25, 2026
Merged

Update JWT core package so the latest Token Factory supporting Cognito token gets used for Google groups auth.#210
Duslerke merged 1 commit intodevelopmentfrom
bump-jwt-for-cognito-token-support

Conversation

@Duslerke
Copy link
Copy Markdown
Contributor

What:

  • Update the Hackney.Core.JWT package 2 versions up (1.72 -> 1.84 -> 1.87).

Why:

  • To get the latest version of the ITokenFactory implementation that adds support for the Cognito token schema.
  • The current v1.72 implementation crashes upon encountering Cognito Token due to empty groups key failing to map and leading Token.Groups to getting set as unhandled null.

Notes:

  • Updating only the JWT core package without the Authorizer as after additional digging through source code I've found that Authorizer core package merely references the JWT core package's ITokenFactory interface definition, and does not do anything more with the package. The way the Google groups authentication setup works is that for any given API, it uses JWT core package to register TokenFactory instance DI, and then that gets used by the Authorizer middleware to populate its Auth filter dependencies. The rest of the JWT usage seems to be limited down to Token class to extract data like email or user name for Activity History purposes.
  • Not updating the Authorizer as it seems to have additional functionality introduced apart JWT version upgrade, that would need extra testing. As it stands right now, due to the above reason, it does not need to be bumped on the APIs.
  • The version 1.84 was a fake release, accidentally triggered by some house cleaning done by the cyber team.
  • What changes does latest JWT intoduce? See PR: Add cognito authentication flow token schema support. lbh-core#68.

@Duslerke Duslerke requested a review from a team as a code owner February 25, 2026 15:55
Copy link
Copy Markdown

@martapederiva martapederiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me liberally bestowing the last of my useless approvals

Image

@Duslerke
Copy link
Copy Markdown
Contributor Author

/me liberally bestowing the last of my useless approvals

Image

It's the thought that counts! 😂

@Duslerke
Copy link
Copy Markdown
Contributor Author

Duslerke commented Feb 25, 2026

That which fails within a unit test is not even related to the package, or API in general. It's a step function step of a nightly process:
/app/HousingFinanceInterimApi/V1/UseCase/RefreshOperatingBalanceUseCase.cs:line 30

Test is flaky.

@Duslerke Duslerke merged commit ad74557 into development Feb 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants