TS-2029: Disable block suspension/unsuspension#91
Open
martapederiva wants to merge 19 commits intomasterfrom
Open
TS-2029: Disable block suspension/unsuspension#91martapederiva wants to merge 19 commits intomasterfrom
martapederiva wants to merge 19 commits intomasterfrom
Conversation
LBHTKarki
reviewed
Jun 17, 2025
LBHTKarki
reviewed
Jun 17, 2025
LBHTKarki
reviewed
Jun 17, 2025
ContractsApi/V1/Boundary/Requests/CreateContractRequestObject.cs
Outdated
Show resolved
Hide resolved
LBHTKarki
reviewed
Jun 17, 2025
LBHTKarki
reviewed
Jun 17, 2025
LBHTKarki
reviewed
Jun 17, 2025
ContractsApi/V1/Infrastructure/Exceptions/SuspendingBlockException.cs
Outdated
Show resolved
Hide resolved
LBHTKarki
reviewed
Jun 23, 2025
LBHTKarki
reviewed
Jun 23, 2025
LBHTKarki
reviewed
Jun 23, 2025
LBHTKarki
reviewed
Jun 23, 2025
LBHTKarki
reviewed
Jun 24, 2025
ContractsApi.Tests/V1/Boundary/CreateContractRequestObjectValidatorTests.cs
Outdated
Show resolved
Hide resolved
LBHTKarki
reviewed
Jun 24, 2025
ContractsApi.Tests/V1/Boundary/CreateContractRequestObjectValidatorTests.cs
Outdated
Show resolved
Hide resolved
LBHTKarki
reviewed
Jun 24, 2025
ContractsApi/V1/Boundary/Requests/Validation/CreateContractRequestObjectValidator.cs
Outdated
Show resolved
Hide resolved
LBHTKarki
reviewed
Jun 30, 2025
ContractsApi/V1/Boundary/Requests/Validation/CreateContractRequestObjectValidator.cs
Show resolved
Hide resolved
|
LBHTKarki
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-2029
Describe this PR
What is the problem we're trying to solve
Users need to be able to suspend/unsuspend child units but blocks cannot be suspended.
To make this possible we are finally introducing the concept of PH to contracts, by adding the subentity
ContractManagementIt contains the hierarchical position of the asset to which the contract is tied and a guid to be populated with a potential
ParentContractId.