Skip to content

Add dq test #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 3 commits into from
Jan 6, 2026
Merged

Add dq test #2617

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3670c8c
Update test values
annajgibson Dec 1, 2025
3cf3af2
Update test values; pause housing GX job
annajgibson Dec 1, 2025
63a38bd
add test to look for uniqueness with person and tenancy refs
annajgibson Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,16 @@
import great_expectations.expectations as gxe


class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
column: str = "lpar_per_alt_ref"
description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"
# class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
# column: str = "lpar_per_alt_ref"
# description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"



class PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique(gxe.ExpectCompoundColumnsToBeUnique):
column: list = ["lpar_per_alt_ref", "lpar_tcy_alt_ref"]
description: str = "Expect lpar_per_alt_ref (person ref) and lpar_tcy_alt_ref (tenancy ref) values to be unique"



class PeopleExpectPersonRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):
Expand Down Expand Up @@ -120,7 +127,7 @@ class PeopleExpectPeopleColumnsToMatchOrderedList(

suite = gx.ExpectationSuite(name="people_data_load_suite")

suite.add_expectation(PeopleExpectPersonRefColumnValuesToBeUnique())
suite.add_expectation(PeopleExpectPersonRefTenancyRefColumnValuesToBeUnique())
suite.add_expectation(PeopleExpectTitleToBeInSet())
suite.add_expectation(PeopleExpectPeopleColumnsToMatchOrderedList())
suite.add_expectation(PeopleExpectPersonRefColumnValuesToNotBeNull())
Expand Down