Skip to content

Update gx tests 3 #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 3 commits into from
Dec 17, 2025
Merged

Update gx tests 3 #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d4d1b5
Update test values
annajgibson Dec 1, 2025
fc71678
Update test values; pause housing GX job
annajgibson Dec 1, 2025
c188570
updates to GX tests
annajgibson Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions scripts/helpers/housing_nec_migration_gx_dq_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
sql_config = {
"properties": {"id_field": "LPRO_PROPREF"},
"tenancies": {"id_field": "LTCY_ALT_REF"},
"people": {"id_field": "LPAR_PER_ALT_REF"},
"contacts": {"id_field": "LCDE_LEGACY_REF"},
"arrears_actions": {"id_field": "LACA_PAY_REF"},
"revenue_accounts": {"id_field": "LRAC_PAY_REF"},
"transactions": {"id_field": "LTRN_ALT_REF"},
"addresses": {"id_field": "LAUS_LEGACY_REF"},
"properties": {"id_field": "lpro_propref"},
"tenancies": {"id_field": "ltcy_alt_ref"},
"people": {"id_field": "lpar_per_alt_ref"},
"contacts": {"id_field": "lcde_legacy_ref"},
"arrears_actions": {"id_field": "laca_pay_ref"},
"revenue_accounts": {"id_field": "lrac_pay_ref"},
"transactions": {"id_field": "ltrn_alt_ref"},
"addresses": {"id_field": "laus_legacy_ref"},
}

data_load_list = [
"properties"
# "tenancies",
# "people",
"properties",
"tenancies",
"people"
# "contacts",
# "arrears_actions",
# "revenue_accounts",
Expand All @@ -33,21 +33,21 @@
# "properties_4b",
# "properties_4c",
# "properties_7a",
"full_full_hem_pro_all_dq",
"full_dq_full_dq_hem_pro_all_dq",
],
"tenancies": [
# "tenancies_1a",
# "tenancies_1c",
# "tenancies_2a",
# "tenancies_other",
"tenancies_all",
"full_dq_full_dq_hem_tcy_all_dq",
],
"people": [
# "people_1a",
# "people_1b",
# "people_1c",
# "people_2a",
"people_all"
"full_dq_full_dq_hem_per_all_dq"
],
"contacts": [
# "contacts_1a",
Expand Down
7 changes: 4 additions & 3 deletions scripts/jobs/housing/housing_nec_migration_apply_gx_dq_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
table_list,
)
import scripts.jobs.housing.housing_nec_migration_properties_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_tenancies_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_people_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_tenancies_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_people_data_load_gx_suite

# import scripts.jobs.housing.housing_nec_migration_contacts_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_arrears_actions_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_revenue_accounts_data_load_gx_suite
Expand Down Expand Up @@ -162,7 +163,7 @@ def main():
)
]

table_results_df["unexpected_id_list"] = pd.Series(dtype="object")
table_results_df["unexpected_id_list"] = pd.Series(dtype="string")

for i, row in query_df.iterrows():
try:
Expand Down
107 changes: 72 additions & 35 deletions scripts/jobs/housing/housing_nec_migration_people_data_load_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@


class PeopleExpectPersonRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
column: str = "LPAR_PER_ALT_REF"
description: str = "Expect LPAR_PER_ALT_REF (person ref) values to be unique"
column: str = "lpar_per_alt_ref"
description: str = "Expect lpar_per_alt_ref (person ref) values to be unique"


class PeopleExpectPersonRefColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):
column: str = "LPAR_PER_ALT_REF"
description: str = "Expect LPAR_PER_ALT_REF (person ref) values to not be Null"
column: str = "lpar_per_alt_ref"
description: str = "Expect lpar_per_alt_ref (person ref) values to not be Null"


class PeopleExpectTitleToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = "LPAR_PER_TITLE"
column: str = "lpar_per_title"
value_set: list = [
"DAME",
"DR",
Expand All @@ -39,37 +39,74 @@ class PeopleExpectTitleToBeInSet(gxe.ExpectColumnValuesToBeInSet):
description: str = "Expect title to be one of the set"


class PeopleExpectPeopleColumnsToMatchOrderedList(gxe.ExpectTableColumnsToMatchOrderedList):
class PeopleExpectPeopleColumnsToMatchOrderedList(
gxe.ExpectTableColumnsToMatchOrderedList
):
column_list = [
"LPAR_HOP_START_DATE",
"LPAR_PER_SURNAME",
"LPAR_TCY_ALT_REF",
"LPAR_PER_FORENAME",
"LPAR_HOP_HPSR_CODE",
"LPAR_PER_TITLE",
"LPAR_PER_INITIALS",
"LPAR_PER_DATE_OF_BIRTH",
"LPAR_PER_HOU_DISABLED_IND",
"LPAR_PER_HOU_OAP_IND",
"LPAR_PER_FRV_FGE_CODE",
"LPAR_HOP_HRV_REL_CODE",
"LPAR_PER_HOU_EMPLOYER",
"LPAR_PER_HOU_HRV_HMS_CODE",
"LPAR_PHONE",
"LPAR_HOP_END_DATE",
"LPAR_HOP_HPER_CODE",
"LPAR_TCY_IND",
"LPAR_TIN_MAIN_TENANT_IND",
"LPAR_TIN_START_DATE",
"LPAR_TIN_END_DATE",
"PAR_TIN_HRV_TIR_CODE",
"LPAR_TIN_STAT_SUCCESSOR_IND",
"LPAR_PER_ALT_REF",
"LPAR_PER_FRV_FEO_CODE",
"LPAR_PER_NI_NO",
"LPAR_PER_FRV_HGO_CODE",
"LPAR_PER_FRV_FNL_CODE",
"LPAR_PER_OTHER_NAME"
"lpar_per_surname",
"lpar_per_forename",
"lpar_hop_start_date",
"lpar_tcy_alt_ref",
"lpar_hop_hpsr_code",
"lpar_per_title",
"lpar_per_initials",
"lpar_per_date_of_birth",
"lpar_per_hou_disabled_ind",
"lpar_per_hou_oap_ind",
"lpar_per_frv_fge_code",
"lpar_hop_hrv_rel_code",
"lpar_per_hou_employer",
"lpar_per_hou_hrv_hms_code",
"lpar_phone",
"lpar_hop_end_date",
"lpar_hop_hper_code",
"lpar_tcy_ind",
"lpar_tin_main_tenant_ind",
"lpar_tin_start_date",
"lpar_tin_end_date",
"lpar_tin_hrv_tir_code",
"lpar_tin_stat_successor_ind",
"lpar_per_alt_ref",
"lpar_per_frv_feo_code",
"lpar_per_ni_no",
"lpar_per_frv_hgo_code",
"lpar_per_frv_fnl_code",
"lpar_per_other_name",
"lpar_per_hou_surname_prefix",
"lpar_hou_legacy_ref",
"lpar_ipp_shortname",
"lpar_ipp_placement_ind",
"lpar_ipp_current_ind",
"lpar_ipp_ipt_code",
"lpar_ipp_usr_username",
"lpar_ipp_spr_printer_name",
"lpar_ipp_comments",
"lpar_ipp_vca_code",
"lpar_ipu_aun_code",
"lpar_ipp_staff_id",
"lpar_ipp_cos_code",
"lpar_ipp_hrv_fit_code",
"lpar_type",
"lpar_org_sort_code",
"lpar_org_name",
"lpar_org_short_name",
"lpar_org_frv_oty_code",
"lpar_per_hou_at_risk_ind",
"lpar_per_hou_hrv_ntly_code",
"lpar_per_hou_hrv_sexo_code",
"lpar_per_hou_hrv_rlgn_code",
"lpar_per_hou_hrv_ecst_code",
"lpar_org_current_ind",
"lpar_hop_head_hhold_ind",
"lpar_hhold_group_no",
"lpar_created_date",
"lpar_created_by",
"lpar_modified_date",
"lpar_modified_by",
"lpar_per_hou_end_date",
"lpar_per_hou_hrv_hpe_code",
"lpar_org_dup",
"tranche",
]
description: str = "Expect people load columns to match ordered list exactly"

Expand Down
Loading