Skip to content

Update gx tests 2 #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 3 commits into from
Dec 16, 2025
Merged

Update gx tests 2 #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f15632
Update test values
annajgibson Dec 1, 2025
7ac5f76
Update test values; pause housing GX job
annajgibson Dec 1, 2025
17da175
update DQ test info for unioned properties table
annajgibson Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scripts/helpers/housing_nec_migration_gx_dq_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
}

data_load_list = [
"properties",
"tenancies",
"people",
"contacts",
"arrears_actions",
"revenue_accounts",
# "transactions",
"addresses",
"properties"
# "tenancies",
# "people",
# "contacts",
# "arrears_actions",
# "revenue_accounts",
# # "transactions",
# "addresses",
]

table_list = {
Expand All @@ -33,7 +33,7 @@
# "properties_4b",
# "properties_4c",
# "properties_7a",
"properties_all_tranches",
"full_full_hem_pro_all_dq",
],
"tenancies": [
# "tenancies_1a",
Expand Down
18 changes: 9 additions & 9 deletions scripts/jobs/housing/housing_nec_migration_apply_gx_dq_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
table_list,
)
import scripts.jobs.housing.housing_nec_migration_properties_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_tenancies_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_people_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_contacts_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_arrears_actions_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_revenue_accounts_data_load_gx_suite

# import scripts.jobs.housing.housing_nec_migration_transactions_data_load_gx_suite
import scripts.jobs.housing.housing_nec_migration_addresses_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_tenancies_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_people_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_contacts_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_arrears_actions_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_revenue_accounts_data_load_gx_suite
#
# # import scripts.jobs.housing.housing_nec_migration_transactions_data_load_gx_suite
# import scripts.jobs.housing.housing_nec_migration_addresses_data_load_gx_suite

logging.basicConfig(level=logging.INFO)
logger = logging.getLogger(__name__)
Expand All @@ -44,7 +44,7 @@


def get_sql_query(sql_config, data_load, table):
query = f"SELECT * FROM housing_nec_migration.{table}"
query = f"SELECT * FROM housing_nec_migration_outputs.{table}"
id_field = sql_config.get(data_load).get("id_field")
return query, id_field

Expand Down
12 changes: 5 additions & 7 deletions scripts/jobs/housing/housing_nec_migration_properties_data_load_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class PropertiesExpectPropTypeValuesToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = "LPRO_HOU_PTV_CODE"
value_set: list = [
"CMC",
"CMF",
"CMC",
"GAR",
"FLT",
"HOU",
Expand All @@ -81,17 +81,15 @@ class PropertiesExpectPropTypeValuesToBeInSet(gxe.ExpectColumnValuesToBeInSet):
"CYC",
"DUP",
"BOI",
"LFT",
"CMC",
"CON",
"PLY",

"LFT",
"PLY"
]
description: str = "Expect property type values to be one of the set"


class PropertiesExpectPropColumnsToMatchOrderedList(
gxe.ExpectTableColumnsToMatchOrderedList
):
class PropertiesExpectPropColumnsToMatchOrderedList(gxe.ExpectTableColumnsToMatchOrderedList):
column_list = [
"LPRO_PROPREF",
"LPRO_HOU_FRB",
Expand Down