Skip to content

Add and update tests for tenancies data load #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 1 commit into from
Sep 19, 2025
Merged

Add and update tests for tenancies data load #2456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 98 additions & 43 deletions scripts/jobs/housing/housing_nec_migration_tenancies_data_load_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,66 +15,120 @@ class ExpectTagRefColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
class ExpectTenancyTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = "LTCY_TTY_CODE"
value_set: list = [
"ASH",
"ASY",
"Demoted",
"FRS",
"HAL",
"INT",
"LEA",
"LTA",
"LHS",
"MPA",
"PVG",
"SPS",
"RTM",
"SEC",
"SSE",
"SHO",
"SLL",
"TLA",
"TBB",
"TBBFam",
"DEC",
"THGF",
"THO",
"THL",
"TPL",
"TRA",
"TACCFLAT",
"TGA",
"UNDER18",
"NONSECTA",
"NONSECHR",
"OFFICESE",
"LIVINGRT",
"FRE",
'ASH',
'ASY',
'DEC',
'Demoted',
'FRE',
'FRS',
'HAL',
'LIVINGRT',
'INT',
'LEA',
'LHS',
'LTA',
'MPA',
'NON',
'PVG',
'RTM',
'SEC',
'SHO',
'SLL',
'SPS',
'SSE',
'TACCFLAT',
'TBB',
'TBBFam',
'THO',
'TGA',
'THL',
'THGF',
'TLA',
'TPL',
'TRA',
'UNDER18',
'OFFICESE'
]
description: str = "Expect tenancy type code to contain one of the set"


class ExpectTenureTypeCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = "LTCY_HRV_TTYP_CODE"
value_set: list = [
"Secure",
"NonSec",
"NonRes",
"Leasehold",
"Temporary",
"Freehold",
"Commercial",
"LivingRent"
"SECURE",
"NONSEC",
"NONRES",
"LEASEHOLD",
"TEMPORARY",
"FREEHOLD",
"COMMERCIAL",
"LIVINGRENT"
]
description: str = "Expect tenure type code to be one of the set"


class ExpectTenancyStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = "LTCY_HRV_TST_CODE"
value_set: list = ["Notice", "Decant", "UnautOcc"]
value_set: list = [
"DECANT",
"NOTICE",
"UNAUTHOCC"
]
description: str = "Expect tenancy status code to be one of the set"



class ExpectTenancyColumnsToMatchOrderedList(gxe.ExpectTableColumnsToMatchOrderedList):
column_list = [
"LTCY_ALT_REF",
"LTCY_TTY_CODE",
"LTCY_ACT_START_DATE",
"LTCY_CORRESPOND_NAME",
"LTCY_HRV_TTYP_CODE",
"LTCY_HRV_TSO_CODE",
"LTCY_ACT_END_DATE",
"LTCY_NOTICE_GIVEN_DATE",
"LTCY_NOTICE_REC_DATE",
"LTCY_EXPECTED_END_DATE",
"LTCY_RTB_RECEIVED_DATE",
"LTCY_RTB_ADMITTED_DATE",
"LTCY_RTB_HELD_DATE",
"LTCY_RTB_WITHDRAWN_DATE",
"LTCY_RTB_APP_EXPECTED_END_DATE",
"LTCY_HRV_TST_CODE",
"LTCY_HRV_TNR_CODE",
"LTCY_HRV_RHR_CODE",
"LTCY_HRV_RWR_CODE",
"LTCY_RTB_APP_REFERENCE",
"LTCY_THO_PROPREF1",
"LTCY_THO_START_DATE1",
"LTCY_THO_END_DATE1",
"LTCY_THO_TTR_CODE1",
"LTCY_THO_PROPREF2",
"LTCY_THO_START_DATE2",
"LTCY_THO_END_DATE2",
"LTCY_THO_HRV_TTR_CODE2",
"LTCY_THO_PROPREF3",
"LTCY_THO_START_DATE3",
"LTCY_THO_END_DATE3",
"LTCY_THO_HRV_TTR_CODE3",
"LTCY_THO_PROPREF4",
"LTCY_THO_START_DATE4",
"LTCY_THO_END_DATE4",
"LTCY_THO_HRV_TTR_CODE4",
"LTCY_THO_PROPREF5",
"LTCY_THO_START_DATE5",
"LTCY_THO_END_DATE5",
"LTCY_THO_HRV_TTR_CODE5",
"LTCY_THO_PROPREF6",
"LTCY_THO_START_DATE6",
"LTCY_THO_END_DATE6",
"LTCY_THO_HRV_TTR_CODE6",
"LTCY_PHONE",
"LTCY_REVIEW_DATE"
]
description: str = "Expect tenancy load columns to match ordered list exactly"

arg_key = ["s3_target_location"]
args = getResolvedOptions(sys.argv, arg_key)
locals().update(args)
Expand All @@ -88,4 +142,5 @@ class ExpectTenancyStatusCodeToBeInSet(gxe.ExpectColumnValuesToBeInSet):
suite.add_expectation(ExpectTenancyTypeCodeToBeInSet())
suite.add_expectation(ExpectTenureTypeCodeToBeInSet())
suite.add_expectation(ExpectTenancyStatusCodeToBeInSet())
suite.add_expectation(ExpectTenancyColumnsToMatchOrderedList())
suite = context.suites.add(suite)