Skip to content

amend regex to look for any digit in pattern #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 3 commits into from
May 15, 2025
Merged

amend regex to look for any digit in pattern #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44226f8
amend regex to look for any digit in pattern
annajgibson May 15, 2025
6fa6cbd
amend regex to look for any digit in pattern
annajgibson May 15, 2025
4d911a9
Merge branch 'main' into di-620-dq-tests-for-nec-estates-loads
annajgibson May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/jobs/housing/housing_dwellings_list_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class ExpectLLPGColumnValueLengthsBetween(gxe.ExpectColumnValueLengthsToBeBetwee

class ExpectBlockRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
column: str = "block_reference_number"
regex: str = r"^[0-9]\d+$"
description: str = "Expect Block Reference Number to match regex ^[0-9]\d+$ (numerical)"
regex: str = r"^\d+$"
description: str = "Expect Block Reference Number to match regex ^\d+$ (numerical)"


class ExpectLLPGColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
Expand All @@ -43,8 +43,8 @@ class ExpectLLPGColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):

class ExpectEstateRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
column: str = "estate_reference_number"
regex: str = r"^[0-9]\d+$"
description: str = "Expect Estate Reference Number to match regex ^[0-9]\d+$ (numerical)"
regex: str = r"^\d+$"
description: str = "Expect Estate Reference Number to match regex ^\d+$ (numerical)"


class ExpectTenureValuesToBeInSet(gxe.ExpectColumnValuesToBeInSet):
Expand Down
8 changes: 4 additions & 4 deletions scripts/jobs/housing/housing_homeowner_record_sheet_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ class ExpectPropNoColumnValuesToNotBeNull(gxe.ExpectColumnValuesToNotBeNull):

class ExpectPropNoNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
column: str = "property_no"
regex: str = r"^[0-9]\d+$"
description: str = "Expect Property Number Number to match regex ^[0-9]\d+$ (numerical)"
regex: str = r"^\d+$"
description: str = "Expect Property Number Number to match regex ^\d+$ (numerical)"


class ExpectPaymentRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchRegex):
column: str = "payment_ref"
regex: str = r"^[0-9]\d+$"
description: str = "Expect Payment Reference Number to match regex ^[0-9]\d+$ (numerical)"
regex: str = r"^\d+$"
description: str = "Expect Payment Reference Number to match regex ^\d+$ (numerical)"


class ExpectTenureTypeColumnValuesToBeInSet(gxe.ExpectColumnValuesToBeInSet):
Expand Down
Loading