Skip to content

Di 447 update data quality tests #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 7 commits into from
Mar 13, 2025
Merged

Di 447 update data quality tests #2174

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ccd1a92
- add dq dimension type for new test
annajgibson Mar 12, 2025
dad89ab
- amend dq dimension types for new test
annajgibson Mar 12, 2025
7aa9abb
- amend dq dimension types for expect_tenure_values_to_be_in_set
annajgibson Mar 13, 2025
1145bd7
Merge branch 'main' into di-447-update-data-quality-tests
annajgibson Mar 13, 2025
4d7c847
Merge branch 'main' into di-447-update-data-quality-tests
annajgibson Mar 13, 2025
74dcbbf
Merge branch 'main' into di-447-update-data-quality-tests
annajgibson Mar 13, 2025
e4fa9df
Merge branch 'main' into di-447-update-data-quality-tests
annajgibson Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions scripts/helpers/housing_gx_dq_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,13 @@
partition_keys = ['import_year', 'import_month', 'import_day', 'import_date']

dq_dimensions_map = {
'expect_arr_patch_not_to_be_null': 'COMPLETENESS',
'expect_asset_id_not_to_be_null': 'COMPLETENESS',
'expect_asset_type_not_to_be_null': 'COMPLETENESS',
'expect_asset_type_values_to_be_in_set': 'CONSISTENCY',
'expect_block_ref_no_column_values_to_match_regex': 'ACCURACY',
'expect_co_t_not_to_be_null': 'COMPLETENESS',
'expect_co_t_to_be_between': 'VALIDITY',
'expect_column_value_lengths_to_be_between': 'VALIDITY',
'expect_column_values_to_be_in_set': 'CONSISTENCY',
'expect_column_values_to_be_unique': 'UNIQUENESS',
Expand All @@ -47,8 +50,11 @@
'expect_date_of_birth_column_values_to_not_be_null': 'COMPLETENESS',
'expect_date_of_birth_to_be_between': 'VALIDITY',
'expect_description_values_to_be_in_set': 'CONSISTENCY',
'expect_end_of_tenure_date_column_to_be_null': 'COMPLETENESS',
'expect_eo_t_to_be_between': 'VALIDITY',
'expect_estate_ref_no_column_values_to_match_regex': 'ACCURACY',
'expect_first_name_column_value_length': 'ACCURACY',
'expect_firstname_column_value_length': 'ACCURACY',
'expect_is_organisation_column_values_to_not_be_null': 'COMPLETENESS',
'expect_is_organisation_values_to_be_in_set': 'CONSISTENCY',
'expect_llpg_and_prop_ref_column_values_to_be_unique_within_record': 'UNIQUENESS',
Expand All @@ -70,36 +76,31 @@
'expect_prop_no_column_values_to_be_unique': 'UNIQUENESS',
'expect_prop_no_column_values_to_not_be_null': 'COMPLETENESS',
'expect_prop_no_no_column_values_to_match_regex': 'ACCURACY',
'expect_prop_ref_column_values_to_be_unique': 'UNIQUENESS',
'expect_prop_ref_not_to_be_null': 'COMPLETENESS',
'expect_property_ref_column_values_to_not_be_null': 'COMPLETENESS',
'expect_rent_group_ref_not_to_be_null': 'COMPLETENESS',
'expect_saff_rent_acc_not_to_be_null': 'COMPLETENESS',
'expect_select_column_values_to_be_unique_within_record': 'UNIQUENESS',
'expect_start_of_tenure_date_column_not_to_be_null': 'COMPLETENESS',
'expect_end_of_tenure_date_column_to_be_null': 'COMPLETENESS',
'expect_sub_type_column_values_to_be_in_set': 'CONSISTENCY',
'expect_sub_type_column_values_to_not_be_null': 'COMPLETENESS',
'expect_surname_column_value_length': 'ACCURACY',
'expect_firstname_column_value_length': 'ACCURACY',
'expect_tag_ref_column_not_to_be_null': 'COMPLETENESS',
'expect_tag_ref_column_values_to_be_unique': 'UNIQUENESS',
'expect_tag_ref_not_to_be_null': 'COMPLETENESS',
'expect_target_id_and_value_column_values_to_be_unique_within_record': 'UNIQUENESS',
'expect_target_id_column_values_to_not_be_null': 'COMPLETENESS',
'expect_target_type_column_values_to_be_in_set': 'CONSISTENCY',
'expect_tenancy_id_and_payment_reference_column_values_to_be_unique_within_record': 'UNIQUENESS',
'expect_tenancy_id_and_property_reference_column_values_to_be_unique_within_record': 'UNIQUENESS',
'expect_tenancy_id_column_not_to_be_null': 'COMPLETENESS',
'expect_tenure_code_column_not_to_be_null': 'COMPLETENESS',
'expect_tenure_type_column_values_to_be_in_set': 'CONSISTENCY',
'expect_tenure_code_values_to_be_in_set': 'CONSISTENCY',
'expect_tenure_not_to_be_null': 'COMPLETENESS',
'expect_tenure_type_column_values_to_be_in_set': 'CONSISTENCY',
'expect_tenure_values_to_be_in_set': 'CONSISTENCY',
'expect_uprn_column_value_lengths_between': 'VALIDITY',
'expect_uprn_column_values_to_match_regex': 'ACCURACY',
'expect_uprn_column_values_to_not_be_null': 'COMPLETENESS',
'expect_uprn_not_to_be_null': 'COMPLETENESS',
'expect_tag_ref_column_values_to_be_unique': 'UNIQUENESS',
'expect_tag_ref_not_to_be_null': 'COMPLETENESS',
'expect_prop_ref_not_to_be_null': 'COMPLETENESS',
'expect_co_t_not_to_be_null': 'COMPLETENESS',
'expect_tenure_not_to_be_null': 'COMPLETENESS',
'expect_saff_rent_acc_not_to_be_null': 'COMPLETENESS',
'expect_rent_group_ref_not_to_be_null': 'COMPLETENESS',
'expect_eo_t_to_be_between': 'VALIDITY',
'expect_co_t_to_be_between': 'VALIDITY',
'expect_prop_ref_column_values_to_be_unique': 'UNIQUENESS',
'expect_arr_patch_not_to_be_null': 'COMPLETENESS'}
'expect_uprn_not_to_be_null': 'COMPLETENESS'}
Loading