fix taxcomi create daily snapshot by changing push_down_predicate#2164
Merged
fix taxcomi create daily snapshot by changing push_down_predicate#2164
Conversation
|
timburke-hackit
approved these changes
Mar 11, 2025
Tian-2017
deleted the
fix-tascomi_create_daily_snapshot_planning-timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the push_down_predicate to 30 days ago instead of using "
20210101"Fix the timeout issue – it was using 20210101 as the push_down_predicate. After reading the playbook, which mentions that it only needs to get the latest records compared to the last snapshot and then Creation of a full snapshot by applying the daily increment to the previous snapshot; Therefore, there's no need to use
20210101as the push_down_predicate when deriving the new records.