Skip to content

- add test to check correct tenure types used #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annajgibson merged 2 commits into from
Mar 5, 2025
Merged

- add test to check correct tenure types used #2153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c0eef
- add test to check correct tenure types used
annajgibson Mar 5, 2025
b66056d
Merge branch 'main' into di-447-update-data-quality-tests
annajgibson Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/jobs/housing/housing_dwellings_list_gx_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import great_expectations as gx
import great_expectations.expectations as gxe


class ExpectLLPGColumnValuesToBeUnique(gxe.ExpectColumnValuesToBeUnique):
column: str = 'llpg'
description: str = "Expect UPRN (LLPG) values to be unique"
Expand Down Expand Up @@ -46,6 +47,14 @@ class ExpectEstateRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchReg
description: str = "Expect Estate Reference Number to match regex ^[0-9]\d+$ (numerical)"


class ExpectTenureValuesToBeInSet(gxe.ExpectColumnValuesToBeInSet):
column: str = 'tenure'
value_set: list = ['Asylum Seeker', 'Freehold', 'Freehold (Serv)', 'Introductory',
'Leasehold (RTB)', 'Lse 100% Stair', 'Mesne Profit Ac', 'Non-Secure',
'Private Sale LH', 'Secure', 'Shared Owners', 'Short Life Lse', 'Temp Decant',
'Shared Equity']
description: str = "Expect tenure values to contain one of the set"


arg_key = ['s3_target_location']
args = getResolvedOptions(sys.argv, arg_key)
Expand All @@ -63,5 +72,6 @@ class ExpectEstateRefNoColumnValuesToMatchRegex(gxe.ExpectColumnValuesToMatchReg
suite.add_expectation(ExpectBlockRefNoColumnValuesToMatchRegex())
suite.add_expectation(ExpectLLPGColumnValuesToMatchRegex())
suite.add_expectation(ExpectEstateRefNoColumnValuesToMatchRegex())
suite.add_expectation(ExpectTenureValuesToBeInSet())

suite = context.suites.add(suite)
Loading