Fix archaeology workflow Python cache setup#35
Merged
Conversation
The scheduled archaeology job failed before DevArch ran because setup-python tried to discover pip dependency files that this legacy setup.py package does not have. Pointing the cache at setup.py keeps the cache explicit and the job unblocked. Tested: actionlint .github/workflows/archaeology.yml Tested: git diff --check Tested: static assertion that setup.py exists and cache-dependency-path references it
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo targeted updates to the DevArch Archaeology Report workflow: the Python setup step now explicitly declares ChangesGitHub Actions Workflow Configuration Fix
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-pythonpip cache atsetup.py, matching this repo's legacy package shape$GITHUB_ENVin the project-name bootstrap step so the workflow passes actionlint cleanlyWhy
The latest default-branch
DevArch Archaeology Reportfailed before DevArch ran becausesetup-pythoncould not find its default pip cache dependency files (requirements.txtorpyproject.toml). This repo currently hassetup.py, so the cache dependency path needs to be explicit.Fixes #34.
Verification
actionlint .github/workflows/archaeology.ymlgit diff --checksetup.pyexists and.github/workflows/archaeology.ymlreferences it ascache-dependency-pathNeed help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit