✨개인정보 AES암호화#171
Merged
kimyeoungrok merged 12 commits intodevfrom Dec 30, 2025
Merged
Conversation
⚙️ README.md 파일 추가
minzix
reviewed
Dec 27, 2025
| if (encrypted == null) return null | ||
| return try { | ||
| val decoded = Base64.getDecoder().decode(encrypted) | ||
| require(decoded.size > GCM_IV_LENGTH) { "Invalid encrypted text" } |
Member
There was a problem hiding this comment.
IV에 TAG 길이를 더하여 같이 고려해서 검증하면 더 좋을 거 같습니다!
minzix
reviewed
Dec 27, 2025
| } | ||
|
|
||
| override fun convertToDatabaseColumn(raw: String?): String? { | ||
| if (raw == null) return null |
Member
There was a problem hiding this comment.
검증 시 null 뿐 아니라 빈 문자열이나 공백을 포함하는 문자열 등의 케이스도 같이 고려하면 더 좋을 거 같아요!
Contributor
Author
There was a problem hiding this comment.
공백을 포함하는 문자열도 처리했으면 좋겠다는 말은 공백을 포함했을 때 에러나 null을 반환하라는 거야 아님 공백을 포함하면 (" hello" -> "hello")와 같이 공백을 제거하라는 뜻이야?
Member
There was a problem hiding this comment.
음 난 전자로 생각하긴 했는데 다시 보니까 null 일때만 null을 반환하는게 더 명확하려나..? 그대로 가도 괜찮을 거 같기도 해요
Contributor
Author
There was a problem hiding this comment.
그럼 null말고 완전 공백인 것들도 추가로 null값 반환하는 것까지만 할게!
Member
|
수고 많으셨습니다!! 코멘트 확인 후 머지해주시면 될 거 같습니당 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
#170
📌 Task Details
💬 Review Requirements (Optional)
암복호화시 에러가 나면 다음과 같이 뜸
일부러 미등록 뜨게 해놓음(암복호화 에러라고 굳이 프론트에 띄울 필요는 없는 것 같음)
하지만 서버 로그에는 원인 파악 가능하게 로그하고 에러 뜨게 해 놓음(에러 처리 전엔 아무 것도 안 떴음)
