fix(runtime): validate GUI and backend build identity#735
Closed
musnows wants to merge 2 commits into
Closed
Conversation
Collaborator
|
我这边 review 了一下,这个 PR 先别合。核心问题不是 build/version mismatch guard 这个方向,而是当前 build identity 的来源不可靠。 现在 建议把 hash/version 改成构建时自动注入,或者至少加 CI 校验让这些常量必须等于当前 HEAD SHA、过期就失败。更理想的是 GUI 和 Kun runtime 在 build 前由同一个脚本生成各自的 identity 文件,避免手写漂移。这个来源变成自动且防过期之后,这个 runtime mismatch guard 就可以继续合。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/health.Changes
Tests
npm run test -- src/main/kun-health.test.ts src/renderer/src/agent/kun-runtime.test.ts src/main/build-identity.test.tsnpm run typechecknpm run build:kungit diff --check