This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Add option to Datafeed class to enable specific topics#26
Open
Azurethi wants to merge 1 commit intoKucoin:masterfrom
Open
Add option to Datafeed class to enable specific topics#26Azurethi wants to merge 1 commit intoKucoin:masterfrom
Azurethi wants to merge 1 commit intoKucoin:masterfrom
Conversation
- removes need for topic check in listeners - defaults to false for backwards compatability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the constructor of the Datafeed class in src/lib/datafeed.js to take an additional Boolean parameter which defaults to false for backward compatibility.
When true, this enables "specific topics", where the topic listeners are added without taking the the prefix of their respective topic. This eliminates the usual check for each topic in the example below. I feel this is much more in line with the expected behaviour of Datafeed.subscribe(topic, hook) and definitely saves me a few lines when using the library.
It may be an idea in future to allow the creation of hooks which listen to multiple topics, however it would make more sense to have a separate set of functions for this.