Skip to content

feat: enhance wait_for_ready() on policies. #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
crstrn13 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: enhance wait_for_ready() on policies. #847

crstrn13 wants to merge 3 commits into from

Conversation

@crstrn13
Copy link
Contributor

@crstrn13 crstrn13 commented Jan 19, 2026

Description

This PR introduces EnvoyWaitMixin which leverages the kuadrant_configs metric exposed by the WASM shim. This metric increments each time the WASM
configuration changes, providing a reliable indicator of actual data plane readiness.

Two-phase wait mechanism:

  1. Control Plane: Wait for K8s policy status (Enforced: True, observedGeneration match)
  2. Data Plane: Wait for kuadrant_configs metric to increase (confirms WASM config applied)

Changes

  • Added EnvoyWaitMixin
    • Provides set_metrics_route() to capture baseline metric value
    • Provides wait_for_envoy_applied() to poll for metric increase
    • Automatically integrated into Policy.wait_for_ready()
  • Updated fixtures
    • Route fixture sets metrics_route to enable Envoy waiting
    • Proper fixture ordering ensures routes exist before policies are committed

Closes: #846

@crstrn13 crstrn13 force-pushed the envoy_wait_mixin branch 2 times, most recently from 80700f6 to 24acf6d Compare January 20, 2026 08:31
@crstrn13 crstrn13 self-assigned this Jan 20, 2026
@crstrn13 crstrn13 requested review from averevki and azgabur January 20, 2026 09:10
azgabur
azgabur reviewed Jan 20, 2026
View reviewed changes
testsuite/tests/singlecluster/conftest.py Outdated
if not kuadrant:
return None

route = OpenshiftRoute.create_instance(
Copy link
Contributor

@azgabur azgabur Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using OpenshiftRoute for every gateway will make the testsuite incompatible with Kind/Kubernetes.

Copy link
Contributor Author

@crstrn13 crstrn13 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. I should use the exposer to expose that.

@crstrn13 crstrn13 force-pushed the envoy_wait_mixin branch 2 times, most recently from e304df5 to 5c2b364 Compare January 20, 2026 11:37
@crstrn13
feat: added envoy wait mixin.
016d934 
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
@crstrn13
feat: added service class for the metrics endpoint on the gateway.
2325864 
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
@crstrn13
fix: cosmetic changes.
669463d 
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azgabur azgabur azgabur left review comments

@averevki averevki Awaiting requested review from averevki

At least 2 approving reviews are required to merge this pull request.

Assignees

@crstrn13 crstrn13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance wait_for_ready() on policies

3 participants

@crstrn13 @azgabur