Expire images #29
Draft
Expire images #29
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dd <4183971+didierofrivia@users.noreply.github.com>
Signed-off-by: dd <4183971+didierofrivia@users.noreply.github.com>
didierofrivia
commented
Jan 22, 2026
| echo "Setting expiry to 'never' for release tag ${{ github.ref_name }}" | ||
| else | ||
| echo "expiry=3w" >> $GITHUB_OUTPUT | ||
| echo "Setting expiry to '3w' for non-release ref ${{ github.ref_name }}" |
Member
Author
There was a problem hiding this comment.
We could change this and make it open and read the value from input
didierofrivia
commented
Jan 22, 2026
| - name: Determine quay image expiry | ||
| id: quay-expiry | ||
| run: | | ||
| if [[ "${{ github.ref_type }}" == "tag" && "${{ github.ref_name }}" =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-.*)?$ ]]; then |
Member
Author
There was a problem hiding this comment.
We could also just change the Makefile value
developer-portal-controller/Makefile
Line 11 in 16e5f8e
QUAY_IMAGE_EXPIRY to never when triggering the release workflow, and let 3w as the default... what do you reckon?
Member
Author
There was a problem hiding this comment.
Same way it's changing the VERSION here
developer-portal-controller/.github/workflows/automated-release.yaml
Lines 52 to 59 in 16e5f8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
TODO