[Core] Replace explicit functions with lambdas in add_constitutive_law_to_python.cpp
#13588
+127
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aw_to_python.cpp`
loumalouomega
added
Cleanup
Kratos Core
Python
FastPR
Member
|
I am quite sure that we used lambdas only as temp solution while we still had C++11 I think the proper solution is |
Member
Author
I am unable to compile in Windows, I tried this already |
Member
|
can you post the error? Then again, its already used in other places |
Member
Author
I did some test, can you point me where are we using it? |
Member
|
just search |
Member
Author
Looks like fixed |
Member
Author
👋 |
philbucher
reviewed
Aug 3, 2025
Comment on lines
+100
to
+129
| .def("Create", static_cast<ConstitutiveLaw::Pointer(ConstitutiveLaw::*)(Kratos::Parameters) const>(&ConstitutiveLaw::Create)) | ||
| .def("Create", static_cast<ConstitutiveLaw::Pointer(ConstitutiveLaw::*)(Kratos::Parameters, const Properties&) const>(&ConstitutiveLaw::Create)) | ||
| .def("WorkingSpaceDimension", &ConstitutiveLaw::WorkingSpaceDimension) | ||
| .def("GetStrainSize", &ConstitutiveLaw::GetStrainSize) | ||
| .def("GetStressMeasure", &ConstitutiveLaw::GetStressMeasure) | ||
| .def("IsIncremental", &ConstitutiveLaw::IsIncremental) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<bool>&)>(&ConstitutiveLaw::Has)) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<int>&)>(&ConstitutiveLaw::Has)) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<double>&)>(&ConstitutiveLaw::Has)) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<array_1d<double, 3>>&)>(&ConstitutiveLaw::Has)) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<Vector>&)>(&ConstitutiveLaw::Has)) | ||
| .def("Has", static_cast<bool (ConstitutiveLaw::*)(const Variable<Matrix>&)>(&ConstitutiveLaw::Has)) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<bool>& rVar) { bool v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<int>& rVar) { int v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<double>& rVar) { double v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<array_1d<double, 3>>& rVar) { array_1d<double, 3> v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<Vector>& rVar) { Vector v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("GetValue", [](ConstitutiveLaw& rCL, const Variable<Matrix>& rVar) { Matrix v; rCL.GetValue(rVar, v); return v; }) | ||
| .def("SetValue", py::overload_cast<const Variable<int>&, const int&, const ProcessInfo&>(&ConstitutiveLaw::SetValue)) | ||
| .def("SetValue", py::overload_cast<const Variable<double>&, const double&, const ProcessInfo&>(&ConstitutiveLaw::SetValue)) | ||
| .def("SetValue", py::overload_cast<const Variable<array_1d<double, 3>>&, const array_1d<double, 3>&, const ProcessInfo&>(&ConstitutiveLaw::SetValue)) | ||
| .def("SetValue", py::overload_cast<const Variable<Vector>&, const Vector&, const ProcessInfo&>(&ConstitutiveLaw::SetValue)) | ||
| .def("SetValue", py::overload_cast<const Variable<Matrix>&, const Matrix&, const ProcessInfo&>(&ConstitutiveLaw::SetValue)) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<bool>& rVar) { bool v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<int>& rVar) { int v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<double>& rVar) { double v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<array_1d<double, 3>>& rVar) { array_1d<double, 3> v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<Vector>& rVar) { Vector v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateValue", [](ConstitutiveLaw& rCL, ConstitutiveLaw::Parameters& rP, const Variable<Matrix>& rVar) { Matrix v; rCL.CalculateValue(rP, rVar, v); return v; }) | ||
| .def("CalculateMaterialResponse", &ConstitutiveLaw::CalculateMaterialResponse) |
Member
There was a problem hiding this comment.
Why not use overload_cast here?
| .def("PushForwardConstitutiveMatrix", &ConstitutiveLaw::PushForwardConstitutiveMatrix) | ||
| .def("Check", &ConstitutiveLaw::Check) | ||
| .def("GetLawFeatures", &ConstitutiveLaw::GetLawFeatures) | ||
| .def("Info", [](const ConstitutiveLaw& rThisConstitutiveLaw){return rThisConstitutiveLaw.Info();}) |
Member
Author
|
What is the status of this? |
Member
|
waiting for answers in the unresolved threads |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Replaced explicit global functions with inline lambda expressions for pybind11 bindings in
kratos/python/add_constitutive_law_to_python.cpp.This change improves code readability and conciseness by defining the wrapper functions directly where they are used.
🆕 Changelog
add_constitutive_law_to_python.cpp