[Core] Refactor UblasSpace to use ParallelUtilities
#13492
+193
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces direct `OpenMP` pragmas in `kratos/spaces/ublas_space.h` with Kratos `ParallelUtilities` (primarily `IndexPartition`). This change modernizes the shared-memory parallelism approach in UblasSpace, aligning it with the recommended Kratos API. The following functions were refactored: - `Copy` (VectorType) - `Dot` - `TwoNorm` (`Matrix` and `compressed_matrix`) - `JacobiNorm` (`Matrix`) - `Mult` (`compressed_matrix`, via ParallelProductNoAdd) - `InplaceMult` - `Assign` - `UnaliasedAdd` - `ResizeData` (all three overloads) - `SetToZero` (all three overloads) - The private helper `ParallelProductNoAdd` was significantly refactored to use `IndexPartition`, and its own helpers `CreatePartition` and `partial_product_no_add` were removed. Reductions were handled using Kratos reducer objects like `SumReduction`.
loumalouomega
added
Kratos Core
Parallel-SMP
Member
Author
|
Funny thing is that I think I found several bugs with this. Tests failing are due to incorrect size vectors. |
…eturn the sensitivity variable string
…the utility function
…r int, bool, double, array_1d, vector, and Matrix type variables.
…ivity variables like SHAPE_SENSITIVITY
Co-authored-by: Suneth Warnakulasuriya <7856520+sunethwarna@users.noreply.github.com>
Changes include: - The UDSM-based constitutive laws are no longer copy-able. Use member function `Clone` for creating deep copies. These constitutive laws are still not moveable. Compile-time checks have been added to enforce this part of the design. - By introducing a data member of type `ConstitutiveLawDimension`, we have been able to generalize class `SmallStrainUDSM3DLaw` such that class `SmallStrainUDSM2DPlaneStrainLaw` became redundant. The new data member is used for getting the strain size as well as the local space dimension. Consequently, we could get rid of static data members `VoigtSize` and `Dimension`. - Class `SmallStrainUDSM3DLaw` has been renamed to `SmallStrainUDSMLaw`. The corresponding files have been renamed, too. Class `SmallStrainUDSM2DPlaneStrainLaw` has been removed. - Moved function definitions from header files to the corresponding implementation files. - Removed a few `override`s that were identical to the base class implementation. - Removed many redundant comments. - Removed several redundant name qualifiers. - Removed several unused member functions. - Corrected the implementations of `save` and `load`, and made them more complete. - Removed several `KRATOS_TRY` and `KRATOS_CATCH` constructs, to avoid catching errors in places where they can't be handled properly anyway. - Made the implementation of member `Clone` complete (several data members were not handled). - Use square brackets (i.e. `[]`) rather than parentheses (i.e. `()`) to access vector entries. This is in line with how the STL accesses elements of containers. - Renamed function parameters `rThisVariable` to `rVariable`.
Member
RiccardoRossi
left a comment
RiccardoRossi
left a comment
There was a problem hiding this comment.
minor comments. ignore if you dislike them
…h IndexPartition for better performance
…ved parallelism and performance
Member
Author
|
Should be fine now @RiccardoRossi |
…or improved parallelism and performance" This reverts commit ceacb6f.
Member
Author
Ping @RiccardoRossi |
Member
Author
Hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR replaces direct
OpenMPpragmas inkratos/spaces/ublas_space.hwith KratosParallelUtilities(primarilyIndexPartition).This change modernizes the shared-memory parallelism approach in UblasSpace, aligning it with the recommended Kratos API.
The following functions were refactored:
Copy(VectorType)DotTwoNorm(Matrixandcompressed_matrix)JacobiNorm(Matrix)Mult(compressed_matrix, via ParallelProductNoAdd)InplaceMultAssignUnaliasedAddResizeData(all three overloads)SetToZero(all three overloads)ParallelProductNoAddwas significantly refactored to useIndexPartition, and its own helpersCreatePartitionandpartial_product_no_addwere removed. (TODO)Reductions were handled using Kratos reducer objects like
SumReduction.🆕 Changelog
UblasSpaceto useParallelUtilities