[Core] Adding SearchInBoundingBox into GeometricalObjectsBins
#12601
Conversation
…ore/SearchInBoundingBox-geometricalobjectbins
…cell BB is inside radius.
This reverts commit 0f77915.
…o avoid distance calculation
loumalouomega
requested review from
pooyan-dadvand
and removed request for
a team
| max_point[0] = r_min_point[0] + (I + 1) * mCellSizes[0]; | ||
| max_point[1] = r_min_point[1] + (J + 1) * mCellSizes[1]; | ||
| max_point[2] = r_min_point[2] + (K + 1) * mCellSizes[2]; | ||
|
|
There was a problem hiding this comment.
Sorry, my bad, I thought that this is the bounding box check, not the radius. Then we should check the farthest point....
BTW, do we use this method?
| /***********************************************************************************/ | ||
|
|
||
| void GeometricalObjectsBins::SearchInBoundingBox( | ||
| const PointType& rPoint, |
| * @param rResults The results of the search | ||
| */ | ||
| void SearchInBoundingBox( | ||
| const PointType& rPoint, |
There was a problem hiding this comment.
Why this point? what to be checked?
| * @param rResults The results of the search | ||
| * @tparam TPointIteratorType The type of the point iterator | ||
| */ | ||
| template<typename TPointIteratorType> |
There was a problem hiding this comment.
I don't understand what this method does? The result should not depend on the point!
There was a problem hiding this comment.
I don't understand how do you search without a point to be searched
|
@pooyan-dadvand do you agree with las changes? |
|
@pooyan-dadvand check if this solution fits the comments |
Reminder |
|
@pooyan-dadvand we should retake this BTW |
Ping |
|
@pooyan-dadvand what is the status of this? |
📝 Description
Adding
SearchInBoundingBoxintoGeometricalObjectsBins. Uses as base the developments from Changes from #12599.NOTE: Current implementation checks if the the geometry is inside the given bounding box using the geometry method
HasIntersectionwhich could be expensive. Maybe we need to think an alternative or speed up current implementations.🆕 Changelog
IsInsidemethod toBoundingBoxclass #12600HasIntersectionmethod for performance #12605