Skip to content

Conversation

@loumalouomega
Copy link
Member

📝 Description

Closes #10470. WE have the HasIntersection method, but no method to get the actual intersection points. This method adds the corresponding method is some geometries (where the intersection is already implemented as auxiliary utilities). Using a std::vector, so the number of intersection points can be arbitrary, between 0 (no intersection), to the required size for the specific geometry combination

🆕 Changelog

@loumalouomega loumalouomega requested a review from a team as a code owner November 28, 2022 11:40
@loumalouomega loumalouomega changed the title [Core] Adding to base class GetIntersectionPoints [Core][Geometries] Adding to base class GetIntersectionPoints Nov 29, 2022
Copy link

@ddiezrod ddiezrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, I do not like that the code is duplicated in both classes. but I guess a possible fix for that would go much further than the scope of this PR. We could maybe have a line and triangle base classes to avoid such duplications

loumalouomega and others added 3 commits December 9, 2022 14:04
Co-authored-by: Daniel Diez <ddiez@europe.altair.com>
Co-authored-by: Daniel Diez <ddiez@europe.altair.com>
@ddiezrod
Copy link

We were discussing this today in @KratosMultiphysics/implementation-committee , in principle we agree this is a nice addition to the geometry classes. Only please, to avoid code duplication, try to move the common code to intersection_utilties. @loumalouomega

@pooyan-dadvand
Copy link
Member

Please refer to the #10470 for the discussion we made about this one.

@RiccardoRossi
Copy link
Member

@pooyan-dadvand can we delegate decisions on this to you? we guess you are following this more closely with Vicente

@RiccardoRossi
Copy link
Member

@pooyan-dadvand ping, can you take this over?

@loumalouomega
Copy link
Member Author

@pooyan-dadvand ping, can you take this over?

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

[Core][Geometries][Proposal] GetIntersectionPoints implementation

5 participants