Skip to content

Comments

pass environment to listDeployments instead of env#141

Open
DavidMakin wants to merge 6 commits intoKowalskiTom:mainfrom
Agreena-ApS:main
Open

pass environment to listDeployments instead of env#141
DavidMakin wants to merge 6 commits intoKowalskiTom:mainfrom
Agreena-ApS:main

Conversation

@DavidMakin
Copy link

@DavidMakin DavidMakin commented Apr 11, 2023

Param accepted by listDeployments is named environment not env

name required description
environment no The name of the environment that was deployed to (e.g., staging or production).

@DavidMakin DavidMakin changed the title pass environemnt to listDeployments instead of env pass environment to listDeployments instead of env Apr 11, 2023
@jakub7722
Copy link

@KowalskiTom PLEASE merge this PR. Today I found the hard way that this is a serious issue. TypeScript does not save us from creating any keys in the object -> when passing env instead of environment what this does is that it's getting last deployment from whichever environment had last deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants