-
Notifications
You must be signed in to change notification settings - Fork 43
pb: Add presence check support #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jozott00
wants to merge
4
commits into
grpc-common
Choose a base branch
from
grpc/presence-check
base: grpc-common
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4b2dc3 to
7202c9a
Compare
Member
|
@Jozott00 great and quick job!
|
Collaborator
Author
|
Member
|
@Jozott00 good question, I don't know 😄 Extension classes would be great here |
Member
|
what about interface OuterClassPresence {
val hasField: Boolean
interface InnerClass {
val hasInnerMessageField: Boolean
}
} |
Member
|
Also, please update the conformance regeneration |
3f352f5 to
f6d343c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Even if a field in a message is optional, we can't make it nullable. This is because fields may either have a default value, or we want to be able to access a default value in a nested field such that the parent object must not be null.
However, users must be able to distinguish between a field that was manually set with the default value and one that was not actively set.
Solution
This PR solves this problem by adding a
presenceAPI to each message that contains fields with presence tracking.presenceis an extension getter on the generated message interface that provides ahasXYZgetter for all fields with tracked/explicit presence.This intermediate
presenceobject is employed to ensure concise code completion and minimize the number of suggestions provided by the IDE.The only field type that lacks a
hasXYZgetter while its presence is tracked is theoneoffield. Sinceoneoffields are nullable, they are null if they are not set.