-
Notifications
You must be signed in to change notification settings - Fork 76
update kandy dependencies #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| # Example notebooks Kandy versions | ||
| kandy-notebook = "0.8.1n" | ||
| kandy-stats-notebook = "0.5.0n" | ||
| kandy = "0.8.3-dev-92" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, we only use kandy in notebooks? so only the -n version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, kandy doesn't have a "-n" version now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that works fine? Does it include DataFrame as compileOnly() now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine both in gradle and notebooks, but you need to add dataframe dependency first.
And no, DataFrame is included as implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need to ask user to %use dataframe before kandy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding something like this to our jupyter integration?
onLoaded {
val alreadyLoadedKandy = try {
execute("kandyConfig").value
true
} catch (_: Exception) {
false
}
if (alreadyLoadedKandy) {
display(
"Kandy was found on the notebook classpath. When combined with DataFrame, make sure DataFrame is loaded first; then Kandy.",
null,
)
}
}I think something like that could prevent some confusion :)
| kandy-notebook = "0.8.1n" | ||
| kandy-stats-notebook = "0.5.0n" | ||
| kandy = "0.8.3-dev-92" | ||
| kandy-stats= "0.5.1-dev-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update to 0.8.3 too?
Kandy dependcies updates from #1584