Skip to content

Conversation

@sebkopf
Copy link
Contributor

@sebkopf sebkopf commented Oct 25, 2019

@jen-reeve
easiest to trouble shoot in a pull request since additional commits you make to your branch will just automatically become part of this pull request

i'll leave in line comments below

tube_tipper.scad Outdated
0.25 * tube_spacing])
rotate([0, 71, 0])
cylinder(d = 0.5 * tube_diameter, h = 2 * wall_thickness);
cylinder(d = 0.5 * (tube_diameter + tube_z_stretch), h = 2 * wall_thickness);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works, it will not introduce the right kind of stretch if you add it to the diameter. Better to add a resize([0, 0, tube_diameter + tube_z_stretch]) above the rotate instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change, in the next commit

tube_tipper.scad Outdated
translate([-wall_thickness,
(y - (number_tubes+1)/2) * (tube_diameter + tube_spacing),
-0.5 * (tube_spacing + tube_diameter) + (0.5 + x) * (tube_diameter + tube_z_stretch + tube_spacing)])
-0.5 * (tube_spacing + 0.75 * tube_diameter) + (0.5 + x) * (tube_diameter + tube_z_stretch + tube_spacing)])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this translate does not yet move the bottom row down more, wasn't this already part of the last printing run?
sidenote: I think for the 20degree angle to keep working you should only move the bottom holes lower, the top ones must stay where they are, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the bottom row down was part of the last test, I think I need to move it a little back up so that the bottom of the hole is sitting right at the base.

On the sidenote: yes, that is how angles work, fixing now.

Jen Reeve added 2 commits October 30, 2019 10:51
Fixed several of the comments from the pull request (mostly z stretch related). Still need to fix the height of the top row.
I think I got the top row back into the right spot, will do a small test with the 5 tube
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants