ci: add rust-version MSRV policy #52
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ members = [ | |
| resolver = "3" | ||
|
|
||
| [workspace.package] | ||
| rust-version = "1.75" | ||
|
There was a problem hiding this comment. 🟠 Architect Review — HIGH The declared MSRV Suggestion: Raise Fix in Cursor | Fix in VSCode Claude (Use Cmd/Ctrl + Click for best experience) Prompt for AI Agent 🤖This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** Cargo.toml
**Line:** 16:16
**Comment:**
*HIGH: The declared MSRV `rust-version = "1.75"` is incompatible with the workspace's `edition = "2024"` crates (and `resolver = "3"`), so the project cannot actually build on Rust 1.75 despite advertising that as the minimum supported version.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix |
||
| license = "MIT OR Apache-2.0" | ||
|
|
||
| [workspace.dependencies] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSRV 1.75 incompatible with edition 2024 and resolver 3
High Severity
The
rust-version = "1.75"is incompatible withresolver = "3"and theedition = "2024"used by all workspace crates. Edition 2024 was stabilized in Rust 1.85, so the MSRV needs to be at least"1.85". As-is, this policy is misleading and will cause CI MSRV checks to fail or give a false promise of compatibility with Rust 1.75.Additional Locations (1)
Cargo.toml#L12-L13Reviewed by Cursor Bugbot for commit 7128ea1. Configure here.