-
Notifications
You must be signed in to change notification settings - Fork 0
chore: pin GitHub Actions to fixed SHAs #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| audit: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinned SHAs missing version comments for maintainabilityLow Severity The pinned SHAs lack version-indicating comments, making it impossible to know at a glance which version is in use. The existing Additional Locations (2)Reviewed by Cursor Bugbot for commit 282ea90. Configure here. |
||
| - uses: rustsec/audit-check@v2 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned SHA appears to be v6, not v4
Medium Severity
The SHA
34e114876b0b11c390a56381ad16ebd13914f8d5is labeled ascheckout@v4in the PR description, but this commit has the message "Cleanup actions/checkout@v6 auth style (#2305)" and belongs to the v6 branch. The known v4.3.0 release SHA isb3498302c5c423fa896b97a26bb183df735d08f8, which is entirely different. This silently upgrades four workflows from v4 to v6, which changes credential storage behavior, requires a newer Actions Runner, and uses Node.js 24 instead of Node.js 20.Additional Locations (2)
.github/workflows/cargo-machete.yml#L16-L17.github/workflows/cargo-semver-checks.yml#L11-L12Reviewed by Cursor Bugbot for commit 282ea90. Configure here.