Skip to content

chore: change deny.toml wildcards warn->deny#47

Open
KooshaPari wants to merge 1 commit into
mainfrom
chore/deny-toml-wildcards-deny
Open

chore: change deny.toml wildcards warn->deny#47
KooshaPari wants to merge 1 commit into
mainfrom
chore/deny-toml-wildcards-deny

Conversation

@KooshaPari
Copy link
Copy Markdown
Owner

@KooshaPari KooshaPari commented May 7, 2026

User description

Summary

  • Change wildcards = "warn" to wildcards = "deny" in deny.toml

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com


Note

Low Risk
Low risk configuration change that only affects dependency policy enforcement; it may cause CI failures if any current or future dependencies use wildcard versions.

Overview
Updates deny.toml to change bans.wildcards from "warn" to "deny", making cargo-deny treat wildcard dependency versions as a hard failure instead of a warning.

Reviewed by Cursor Bugbot for commit 4717834. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Block wildcard dependency versions in dependency checks

What Changed

  • Dependency checks now fail instead of warn when a package uses a wildcard version
  • This makes wildcard version usage stop the build instead of passing with a warning

Impact

✅ Fewer wildcard dependency versions
✅ Stricter dependency policy enforcement
✅ Earlier CI failures for unsafe version ranges

🔄 Retrigger CodeAnt AI Review

Details

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI review requested due to automatic review settings May 7, 2026 18:48
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 7, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The deny.toml file is modified to change the [bans] section's wildcards setting from "warn" to "deny". This escalates how Cargo deny treats wildcard dependency versions from warnings to outright rejections.

Changes

Dependency Policy Configuration

Layer / File(s) Summary
Bans Configuration
deny.toml
The wildcards setting in [bans] section is changed from "warn" to "deny", escalating wildcard version specifications to denial severity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: updating deny.toml to change wildcards from warn to deny.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly describes the changeset: updating deny.toml to change wildcards from 'warn' to 'deny', with detailed explanations of the impact and reasoning.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deny-toml-wildcards-deny
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/deny-toml-wildcards-deny

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label May 7, 2026
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 7, 2026

CodeAnt AI finished reviewing your PR.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 7, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • deny.toml - 0 issues

Reviewed by nemotron-3-super-120b-a12b-20230311:free · 123,337 tokens

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deny.toml configuration to change the wildcards setting from warn to deny under the [bans] section, strictly prohibiting wildcard dependencies. There are no review comments to address, and I have no further feedback to provide.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants