Skip to content

docs(iconography): complete Fluent + Material icon sets (20+20)#139

Merged
KooshaPari merged 1 commit into
mainfrom
feat/journey-impl
May 2, 2026
Merged

docs(iconography): complete Fluent + Material icon sets (20+20)#139
KooshaPari merged 1 commit into
mainfrom
feat/journey-impl

Conversation

@KooshaPari
Copy link
Copy Markdown
Owner

@KooshaPari KooshaPari commented May 2, 2026

Summary

  • Complete Fluent icon set to 20 icons (added clock, chart-bar, folder, file, database, key, shield, alert-triangle, build, deploy)
  • Complete Material outline icon set to 20 icons (same 10 + outline variants)
  • All icons validated via Python XML parse

Test plan

  • All 20 Fluent SVGs pass XML validation
  • All 20 Material outline SVGs pass XML validation
  • icons.svg sprite contains all 40 symbol definitions

🤖 Generated with Claude Code


Note

Low Risk
Low risk: adds new documentation SVG assets only, with no runtime code or behavior changes.

Overview
Adds new SVG icon files under docs/operations/iconography/ for Fluent and Material (outline) sets, covering common operational concepts (e.g., alert, build, deploy, data, time, security).

Each icon includes accessible metadata (title, desc, aria-label) and uses currentColor strokes, standardizing how these icons render in docs.

Reviewed by Cursor Bugbot for commit a2f6db9. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 2, 2026 01:37
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 2, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (20)
  • docs/operations/iconography/fluent/alert-triangle.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/build.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/chart-bar.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/clock.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/database.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/deploy.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/file.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/folder.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/key.svg is excluded by !**/*.svg
  • docs/operations/iconography/fluent/shield.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/alert-triangle-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/build-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/chart-bar-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/clock-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/database-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/deploy-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/file-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/folder-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/key-outline.svg is excluded by !**/*.svg
  • docs/operations/iconography/material/shield-outline.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5b1eeb29-4d3d-4392-a56a-fe08ba8128b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
unknown escape sequence in ".coderabbit.yaml" (41:11)

 38 |       - "async_await_patterns"
 39 |     patterns_to_watch:
 40 |       - "^unsafe "
 41 |       - "\.unwrap\(\)"
----------------^
 42 |       - "\.expect\("
 43 |       - "std::panic"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/journey-impl
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/journey-impl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

🔒 Snyk Security Scan Results

Snyk vulnerability scan completed. View results in GitHub Code Scanning dashboard.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

🔒 Snyk Security Scan Results

Snyk vulnerability scan completed. View results in GitHub Code Scanning dashboard.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Legacy Tooling Scan Report

Total violations: 100

Severity Count
critical 0
high 0
medium 100
low 0

Top findings:

  • MEDIUM LT-GEN-005: src/thegent/planning/remediation_planner.py:1
  • MEDIUM LT-GEN-005: tests/test_phench_runtime.py:1
  • MEDIUM LT-GEN-005: tests/bdd/main.rs:1
  • MEDIUM LT-GEN-005: python/src/agileplus_mcp/grpc_client.py:1
  • MEDIUM LT-GEN-005: python/src/agileplus_proto/gen/agileplus/v1/integrations_pb2_grpc.py:1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 2, 2026

CodeAnt AI finished reviewing your PR.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.

<path d="M10.29 3.86L1.82 18a2 2 0 0 0 1.71 3h16.94a2 2 0 0 0 1.71-3L13.71 3.86a2 2 0 0 0-3.42 0z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" fill="none"/>
<line x1="12" y1="9" x2="12" y2="13" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
<line x1="12" y1="17" x2="12.01" y2="17" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>
</svg>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material outline icons violate documented Material spec

Medium Severity

All 10 new Material outline icons use stroke="currentColor" with fill="none", but SPEC.md line 8 defines Material style as fill=currentColor stroke=none. The existing Material icons (e.g., material/dashboard.svg, material/home.svg) correctly follow the spec with fill="currentColor" and filled paths. The new outline icons are styled identically to the Fluent stroke-based icons (differing only in stroke-width 2 vs 1.5), which contradicts the spec's intent that Material icons be filled.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.

<title>Build</title>
<desc>A wrench tool for building and compiling</desc>
<path d="M14.7 6.3a1 1 0 0 0 0 1.4l1.6 1.6a1 1 0 0 0 1.4 0l3.77-3.77a6 6 0 0 1-7.94 7.94l-6.91 6.91a2.12 2.12 0 0 1-3-3l6.91-6.91a6 6 0 0 1 7.94-7.94l-3.76 3.76z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" fill="none"/>
</svg>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material outline icons duplicate Fluent with only stroke-width change

Low Severity

Each of the 10 new Material outline SVGs is an exact copy of its Fluent counterpart with only stroke-width changed from 1.5 to 2 and -outline appended to aria-label. The path data, structure, <title>, and <desc> are all identical. This doubles the maintenance surface for what is effectively a single CSS property difference, increasing the risk of inconsistent fixes when icons are updated.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.

@KooshaPari KooshaPari merged commit e020550 into main May 2, 2026
37 of 59 checks passed
@KooshaPari KooshaPari deleted the feat/journey-impl branch May 2, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants