docs(iconography): complete Fluent + Material icon sets (20+20)#139
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (20)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning
|
🔒 Snyk Security Scan ResultsSnyk vulnerability scan completed. View results in GitHub Code Scanning dashboard. |
1 similar comment
🔒 Snyk Security Scan ResultsSnyk vulnerability scan completed. View results in GitHub Code Scanning dashboard. |
Legacy Tooling Scan ReportTotal violations: 100
Top findings:
|
|
|
CodeAnt AI finished reviewing your PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.
| <path d="M10.29 3.86L1.82 18a2 2 0 0 0 1.71 3h16.94a2 2 0 0 0 1.71-3L13.71 3.86a2 2 0 0 0-3.42 0z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" fill="none"/> | ||
| <line x1="12" y1="9" x2="12" y2="13" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/> | ||
| <line x1="12" y1="17" x2="12.01" y2="17" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/> | ||
| </svg> |
There was a problem hiding this comment.
Material outline icons violate documented Material spec
Medium Severity
All 10 new Material outline icons use stroke="currentColor" with fill="none", but SPEC.md line 8 defines Material style as fill=currentColor stroke=none. The existing Material icons (e.g., material/dashboard.svg, material/home.svg) correctly follow the spec with fill="currentColor" and filled paths. The new outline icons are styled identically to the Fluent stroke-based icons (differing only in stroke-width 2 vs 1.5), which contradicts the spec's intent that Material icons be filled.
Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.
| <title>Build</title> | ||
| <desc>A wrench tool for building and compiling</desc> | ||
| <path d="M14.7 6.3a1 1 0 0 0 0 1.4l1.6 1.6a1 1 0 0 0 1.4 0l3.77-3.77a6 6 0 0 1-7.94 7.94l-6.91 6.91a2.12 2.12 0 0 1-3-3l6.91-6.91a6 6 0 0 1 7.94-7.94l-3.76 3.76z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" fill="none"/> | ||
| </svg> |
There was a problem hiding this comment.
Material outline icons duplicate Fluent with only stroke-width change
Low Severity
Each of the 10 new Material outline SVGs is an exact copy of its Fluent counterpart with only stroke-width changed from 1.5 to 2 and -outline appended to aria-label. The path data, structure, <title>, and <desc> are all identical. This doubles the maintenance surface for what is effectively a single CSS property difference, increasing the risk of inconsistent fixes when icons are updated.
Reviewed by Cursor Bugbot for commit a2f6db9. Configure here.





Summary
Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: adds new documentation SVG assets only, with no runtime code or behavior changes.
Overview
Adds new SVG icon files under
docs/operations/iconography/for Fluent and Material (outline) sets, covering common operational concepts (e.g., alert, build, deploy, data, time, security).Each icon includes accessible metadata (
title,desc,aria-label) and usescurrentColorstrokes, standardizing how these icons render in docs.Reviewed by Cursor Bugbot for commit a2f6db9. Bugbot is set up for automated code reviews on this repo. Configure here.