fix(deploy): inline workflow for phenotype.space#565
Conversation
- Replaced reusable workflow with inline steps - Clone phenodocs to /tmp and symlink @phenotype/docs - Set PHENOTYPE_CUSTOM_DOMAIN=true for root base path - Fixed artifact path to docs/docs/.vitepress/dist
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Snyk Security Scan ResultsSnyk vulnerability scan completed. View results in GitHub Code Scanning dashboard. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fcb5115. Configure here.
| run: | | ||
| # Link @phenotype/docs from phenodocs | ||
| mkdir -p docs/node_modules/@phenotype | ||
| ln -sf /tmp/phenodocs/packages/docs docs/node_modules/@phenotype/docs |
There was a problem hiding this comment.
Symlink created in wrong nested directory path
High Severity
The working-directory: docs is already set for this step, so all commands run inside docs/. The mkdir -p docs/node_modules/@phenotype and ln -sf ... docs/node_modules/@phenotype/docs commands therefore create the symlink at docs/docs/node_modules/@phenotype/docs from the repo root. But bun install (same step, same working directory) uses docs/node_modules/ from repo root. The @phenotype/docs symlink ends up in a path that Node/Bun resolution won't find, causing the build to fail.
Reviewed by Cursor Bugbot for commit fcb5115. Configure here.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)No additional observations outside the changed lines. Files Reviewed (1 files)
Reviewed by laguna-m.1-20260312:free · 494,416 tokens |
Fixes AgilePlus VitePress deployment for phenotype.space custom domain.
Changes:
Note
Medium Risk
Moderate risk because it replaces the previously reused deployment workflow with custom inline steps and changes dependency wiring and artifact paths, which could break Pages builds/deploys if any step/path/token handling is incorrect.
Overview
Replaces the reusable
vitepress-pages.ymlworkflow with an inline GitHub Pages deploy job that checks out the repo, sets up Bun/Pages, installs deps, builds, uploads the artifact, and deploys.The workflow now clones
KooshaPari/phenodocsand symlinks@phenotype/docsintodocs/node_modules, configures GitHub Packages auth viaGITHUB_TOKEN, setsPHENOTYPE_CUSTOM_DOMAIN="true"for the build, and updates the uploaded artifact path todocs/docs/.vitepress/dist.Reviewed by Cursor Bugbot for commit fcb5115. Bugbot is set up for automated code reviews on this repo. Configure here.