Conversation
…h DNS/IP fallback GHASR-89
There was a problem hiding this comment.
Pull request overview
This PR updates the runner job completion hook generated by cloud-init.sh.tmpl to correctly aggregate Zeek NDJSON logs and attribute network bandwidth to a domain using TLS SNI, with a DNS (answer IP → query name) fallback and final fallback to the responder IP.
Changes:
- Extend
send_metricsto optionally append an additional tag fragment for specialized metrics. - Make Zeek log parsing resilient to missing
ssl.loganddns.log(treat as empty). - Replace the prior multi-input
jq -sapproach with--slurpfile-based parsing to properly handle NDJSON and add DNS/IP fallback for domain attribution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raoxiaoyan
approved these changes
Jun 9, 2026
ms2008
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHASR-89