fix(planner): fix api_publication perpetual updates and delete composite ID bug

[Copilot]

api_publication resources were planned for UPDATE on every apply run after initial creation, and DELETE operations used an incorrect composite ID as the portal ID.

Bugs Fixed

Perpetual false-positive UPDATEs (shouldUpdateAPIPublication)

auto_approve_registrations was always compared against a hardcoded false default when not specified in the desired config. If the server returns a non-false value (e.g., when the portal's auto_approve_applications is true), every plan run generates a spurious update.

// Before: always compared, defaults desired to false
desiredAutoApprove := false
if desired.AutoApproveRegistrations != nil {
    desiredAutoApprove = *desired.AutoApproveRegistrations
}
if current.AutoApproveRegistrations != desiredAutoApprove { // perpetual diff

// After: skip comparison entirely when not specified, consistent with visibility/auth_strategy_ids
if desired.AutoApproveRegistrations != nil {
    desiredAutoApprove := *desired.AutoApproveRegistrations
    if current.AutoApproveRegistrations != desiredAutoApprove {

Invalid DELETE calls (planAPIPublicationDelete)

ResourceID was set to "apiID:portalID" composite string. APIPublicationAdapter.Delete passes ResourceID directly as the portalID argument to DeleteAPIPublication, resulting in an API call with an invalid portal ID. Fixed to use only portalID; the API ID is already available via change.Parent.ID.

Test Coverage

• Unit tests for shouldUpdateAPIPublication: nil auto_approve_registrations is ignored, explicit value triggers update, full idempotency when state matches
• New 002-idempotency-check step in portal/visibility e2e scenario: runs plan after initial apply and asserts total_changes: 0

Resolves #37

Related #338

[rspurgeon]

Closed as not applicable to the originating issue