feat(o2k): support x-kong-tags on routes #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for the PR @danielpoonwj . Could you rebase and resolve conflicts please? @Tieske can you review when you have time? I will also give it a look. |
danielpoonwj
force-pushed
the
routes-support-x-kong-tags
branch
from
21f2b72 to
a4d56d3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 68.62% 69.15% +0.52%
==========================================
Files 22 22
Lines 3012 3018 +6
==========================================
+ Hits 2067 2087 +20
+ Misses 797 781 -16
- Partials 148 150 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently
x-kong-tagsis only recognized when set on the document level. There are use cases where additional tags need to be set per route. This PR allowsx-kong-tagsto be set on the operation level as well, which applies it to that specific route.If
x-kong-tagsis set on both the document and operation level, the route would contain tags from both sources. There is currently no deduplication.Refer to the documentation and/or test cases for the syntax and behaviour.