Skip to content

Upgrade vacuum#1748

Open
mheap wants to merge 2 commits intomainfrom
upgrade-vacuum
Open

Upgrade vacuum#1748
mheap wants to merge 2 commits intomainfrom
upgrade-vacuum

Conversation

@mheap
Copy link
Member

@mheap mheap commented Sep 1, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.78%. Comparing base (8ea772d) to head (581d4ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   32.83%   32.78%   -0.05%     
==========================================
  Files          73       73              
  Lines        6557     6557              
==========================================
- Hits         2153     2150       -3     
- Misses       4241     4243       +2     
- Partials      163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mheap
Copy link
Member Author

mheap commented Sep 1, 2025

Data race issue raised at daveshanley/vacuum#702

@mheap mheap force-pushed the upgrade-vacuum branch 4 times, most recently from 4c8eaca to 5bdc7a6 Compare September 16, 2025 09:59
@mheap
Copy link
Member Author

mheap commented Sep 16, 2025

This was fixed in https://github.com/daveshanley/vacuum/releases/tag/v0.18.0

Unfortunately, upstream has also upgraded to YAML v4 (which is an RC), breaking compatibility with speakeasy/jsonpath which uses YAML v3.

For now, we need to wait until v4 is GA, and then wait for Speakeasy to upgrade the jsonpath library

@mheap mheap marked this pull request as ready for review February 3, 2026 12:16
@mheap mheap requested a review from harshadixit12 February 3, 2026 12:16
@mheap
Copy link
Member Author

mheap commented Feb 3, 2026

@harshadixit12 This will fix FTI-6730 from May 2025!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants